From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: check if the fsid in the primary sb and copy sb are same
Date: Thu, 22 Mar 2018 21:37:23 +0800 [thread overview]
Message-ID: <fe3a4c3b-ffd0-a39f-6255-7b17b6b0e32e@oracle.com> (raw)
In-Reply-To: <c94f946d-1447-8644-b6e3-49f7a27d16d3@suse.com>
> So the code per-se makes sense. However, have you came across such a
> case in the real world or are you just fixing a theoretical (but real)
> issue?
As discussed in the other thread, the SB csum check is coming to scan
context as well. Now the question I have is, what do we do if the csum
doesn't match, in the inital version we can fail the mount, but in the
long run potentially we could recover it from the good copy.
So if we have to recover it from the good copy we have to ensure copies
are really copies of the primary SB.
Thanks, Anand
next prev parent reply other threads:[~2018-03-22 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:01 [PATCH v2] handle SB beyond blockcount mkfs.btrfs Anand Jain
2018-03-22 13:01 ` [PATCH v2] btrfs: check if the fsid in the primary sb and copy sb are same Anand Jain
2018-03-22 13:14 ` Nikolay Borisov
2018-03-22 13:37 ` Anand Jain [this message]
2018-03-23 9:39 ` Anand Jain
2018-03-23 12:38 ` [PATCH v2.1] " Anand Jain
2018-03-26 6:35 ` [PATCH v2] handle SB beyond blockcount mkfs.btrfs Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3a4c3b-ffd0-a39f-6255-7b17b6b0e32e@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).