public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz
Cc: Christoph Hellwig <hch@lst.de>,
	clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: move all btree initialization into btrfs_init_btree_inode
Date: Wed, 14 Feb 2024 19:02:08 +1030	[thread overview]
Message-ID: <ff18404f-ca7e-4c48-a3d5-e7fab921ade1@gmx.com> (raw)
In-Reply-To: <20240214071240.GK355@twin.jikos.cz>



在 2024/2/14 17:42, David Sterba 写道:
> On Wed, Feb 14, 2024 at 04:58:55PM +1030, Qu Wenruo wrote:
>>
>>
>> 在 2023/2/20 04:40, Christoph Hellwig 写道:
>>> Move the remaining code that deals with initializing the btree
>>> inode into btrfs_init_btree_inode instead of splitting it between
>>> that helpers and its only caller.
>>>
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Reviewed-by: Qu Wenruo <wqu@suse.com>
>>
>> Just one small nitpick.
>
> The patch is almost one year old, it does not make much sense to send
> reviews, if there's something to be fixed please send a new patch.

My bad, I'm re-setting up my mail client, and this one popped up and I
thought it's new...

Sorry for the noise,
Qu

      reply	other threads:[~2024-02-14  8:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 18:10 [PATCH] btrfs: move all btree initialization into btrfs_init_btree_inode Christoph Hellwig
2023-02-20  8:17 ` Johannes Thumshirn
2023-02-20 20:19 ` David Sterba
2023-02-21 14:28   ` Christoph Hellwig
2023-02-21 14:51     ` David Sterba
2023-02-27  7:35 ` Anand Jain
2023-02-27 13:39   ` Christoph Hellwig
2023-02-27 18:41   ` David Sterba
2024-02-14  6:28 ` Qu Wenruo
2024-02-14  7:12   ` David Sterba
2024-02-14  8:32     ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff18404f-ca7e-4c48-a3d5-e7fab921ade1@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox