Re: compress-force mount option documentation is ambiguous

[Nikolay Borisov <nborisov@suse.com>]

On 18.08.20 г. 9:18 ч., Nikolay Borisov wrote:
> 
> 
> On 17.08.20 г. 23:18 ч., Peter Kese wrote:
>> The `compress-force` mount  option which states:
>>
>> "If compress-force is specified, then compression will always be
>> attempted, but the data may end up uncompressed if the compression
>> would make them larger."
> 
> So which part is ambiguous - it clearly states that so long as
> compress-force is specified compression is _always_ attempted but it
> might not always be performed because of heuristics present that check if
> compressed size < original size. That heuristics is independent of
> whether compression is enabled or not. I.e it is always performed if
> compression is enabled. In this regard I think the text is clear, how
> would you recommend changing the docs?

Huhz I was wrong, indeed if force compress is enabled then even if the
file is made larger then btrfs will still "compress" it.

> 
>>
>> It is unclear  whether that means that compress-force will really
>> ALWAYS attempt compression, or it will respect the +c / -c file
>> attributes?

FORCE_COMPRESS disregards +/- c in this case.


>>
>> Which one is it? Can we fix the documentation?
> 
> 
> 
>> Thanks
>>
>