From: Qu Wenruo <wqu@suse.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/8] btrfs: make subpage handling be feature full
Date: Fri, 28 Feb 2025 13:44:04 +1030 [thread overview]
Message-ID: <ffd5ebe0-541c-4d21-b7dd-f0bbe29c8200@suse.com> (raw)
In-Reply-To: <20250227111603.GB5777@twin.jikos.cz>
在 2025/2/27 21:46, David Sterba 写道:
> On Thu, Feb 27, 2025 at 04:24:38PM +1030, Qu Wenruo wrote:
>> [CHANGLOG]
>> v2:
>> - Add a new bug fix which is exposed by recent 2K block size tests on
>> x86_64
>> It's a self deadlock where the folio_end_writeback() is called with
>> subpage lock hold, and folio_end_writeback() will eventually call
>> btrfs_release_folio() and try to lock the same spin lock.
>>
>> Since the introduction of btrfs subapge support in v5.15, there are
>> quite some limitations:
>>
>> - No RAID56 support
>> Added in v5.19.
>>
>> - No memory efficient scrub support
>> Added in v6.4.
>>
>> - No block perfect compressed write support
>> Previously btrfs requires the dirty range to be fully page aligned, or
>> it will skip compression completely.
>>
>> Added in v6.13.
>>
>> - Various subpage related error handling fixes
>> Added in v6.14.
>>
>> - No support to create inline data extent
>> - No partial uptodate page support
>> This is a long existing optimization supported by EXT4/XFS and
>> is required to pass generic/563 with subpage block size.
>>
>> The last two are addressed in this patchset.
>
> That's great, thank you very much. I think not all patches have a
> reviewed-by tag but I'd like to get it to for-next very soon. The next
> is rc5 and we should have all features in. This also means the 2K
> nodesize block so we can give it more testing.
Now pushed to for-next, with all patches reviewed (or acked) by Filipe.
Great thanks to Filipe for the review!
For the 2K one, since it's just two small patches I'm also fine pushing
them now.
Just do not forget that we need progs patches, and a dozen of known
failures from fstests, and I'm not yet able to address them all any time
soon.
Thanks,
Qu
next prev parent reply other threads:[~2025-02-28 3:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 5:54 [PATCH v2 0/8] btrfs: make subpage handling be feature full Qu Wenruo
2025-02-27 5:54 ` [PATCH v2 1/8] btrfs: prevent inline data extents read from touching blocks beyond its range Qu Wenruo
2025-02-27 5:54 ` [PATCH v2 2/8] btrfs: subpage: do not hold subpage spin lock when clearing folio writeback Qu Wenruo
2025-02-27 12:42 ` Filipe Manana
2025-02-27 5:54 ` [PATCH v2 3/8] btrfs: fix the qgroup data free range for inline data extents Qu Wenruo
2025-02-27 5:54 ` [PATCH v2 4/8] btrfs: introduce a read path dedicated extent lock helper Qu Wenruo
2025-02-27 12:47 ` Filipe Manana
2025-02-27 5:54 ` [PATCH v2 5/8] btrfs: make btrfs_do_readpage() to do block-by-block read Qu Wenruo
2025-02-27 12:48 ` Filipe Manana
2025-02-27 5:54 ` [PATCH v2 6/8] btrfs: allow buffered write to avoid full page read if it's block aligned Qu Wenruo
2025-02-27 5:54 ` [PATCH v2 7/8] btrfs: allow inline data extents creation if block size < page size Qu Wenruo
2025-02-27 5:54 ` [PATCH v2 8/8] btrfs: remove the subpage related warning message Qu Wenruo
2025-02-27 11:16 ` [PATCH v2 0/8] btrfs: make subpage handling be feature full David Sterba
2025-02-28 3:14 ` Qu Wenruo [this message]
2025-02-28 12:42 ` David Sterba
2025-03-02 22:48 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd5ebe0-541c-4d21-b7dd-f0bbe29c8200@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox