Re: [PATCH] Btrfs-progs: allow --init-extent-tree to work when extent tree is borked

[Martin <m_btrfs@ml1.co.uk>]

On 28/10/13 15:11, Josef Bacik wrote:
> On Sun, Oct 27, 2013 at 12:16:12AM +0100, Martin wrote:
>> On 25/10/13 19:31, Josef Bacik wrote:
>>> On Fri, Oct 25, 2013 at 07:27:24PM +0100, Martin wrote:
>>>> On 25/10/13 19:01, Josef Bacik wrote:
>>>>> Unfortunately you can't run --init-extent-tree if you can't actually read the
>>>>> extent root.  Fix this by allowing partial starts with no extent root and then
>>>>> have fsck only check to see if the extent root is uptodate _after_ the check to
>>>>> see if we are init'ing the extent tree.  Thanks,
>>>>>
>>>>> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
>>>>> ---
>>>>>  cmds-check.c |  9 ++++++---
>>>>>  disk-io.c    | 16 ++++++++++++++--
>>>>>  2 files changed, 20 insertions(+), 5 deletions(-)
>>>>>
>>>>> diff --git a/cmds-check.c b/cmds-check.c
>>>>> index 69b0327..8ed7baa 100644
>>>>> --- a/cmds-check.c
>>>>> +++ b/cmds-check.c
>>>>
>>>> Hey! Quick work!...
>>>>
>>>> Is that worth patching locally and trying against my example?
>>>>
>>>
>>> Yes, I'm a little worried about your particular case so I'd like to see if it
>>> works.  If you don't see a lot of output after say 5 minutes let's assume I
>>> didn't fix your problem and let me know so I can make the other change I
>>> considered.  Thanks,
>>
>> Nope... No-go.
>>
> 
> Ok I've sent
> 
> [PATCH] Btrfs-progs: rework open_ctree to take flags, add a new one
> 
> which should address your situation.  Thanks,


Josef,

Tried your patch:

####
Signed-off-by: Josef Bacik <jbacik@fusionio.com>

 13 files changed, 75 insertions(+), 113 deletions(-)

diff --git a/btrfs-convert.c b/btrfs-convert.c
index 26c7b5f..ae10eed 100644
####

And the patching fails due to mismatching code...

I have the Gentoo source for:

Btrfs v0.20-rc1-358-g194aa4a

(On Gentoo 3.11.5, will be on 3.11.6 later today.)


What are the magic incantations to download your version of source code
to try please? (Patched or unpatched?)


Many thanks,
Martin