Re: [PATCH v2] Btrfs-progs: fix unaligned accesses

[Andre Diekwisch <andred@mail.upb.de>]

Arne Jansen <sensille <at> gmx.net> writes:

> 
> There are some unaligned accesses in progs that cause malfunction or
> crashes on ARM.
> This patch fixes the ones we stumbled upon.
> 
> Signed-off-by: Arne Jansen <sensille <at> gmx.net>
> ---
> 
> Change v1->v2:
> Somehow sent the wrong patch without the patch to the setget functions.


Hello,

I reported these unaligned accesses originally and tested this patch on an ARMv5
kirkwood device using a 3.6.2 kernel.
I set /proc/cpu/alignment to 5 (signal+warn), and got no signals anymore using
this patch. I tested mkfs.btrfs, sub list and sub find-new (which all signalled
before the patch) and additionally inspect-internal inode-resolve and btrfsck.

None of them signalled or showed any other issues.
tested-by: Andre Diekwisch <andred <at> mail.upb.de>


Thanks a lot Arne, this patch finally renders btrfs-progs usable on an
ARM-machine without enabling unaligned access trapping for userspace.
I'll report back should I run into more issues regarding unaligned accesses.

Hope this patch gets accepted.