Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Manish <coderinme@outlook.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: Btrfs: check for empty bitmap list in setup_cluster_bitmaps
Date: Wed, 16 Dec 2015 01:48:01 +0000 (UTC)	[thread overview]
Message-ID: <loom.20151216T024617-945@post.gmane.org> (raw)
In-Reply-To: 20151215170827.GA6322@ret.masoncoding.com

Hi Chris,

I have one coding comment for this patch.

Following line can be merged into single:
  if (!list_empty(bitmaps))
     entry = list_first_entry(bitmaps, struct btrfs_free_space, list);


new change as below-:

    entry = list_first_entry_or_null(bitmaps, struct btrfs_free_space,list);


Manish



      parent reply	other threads:[~2015-12-16  1:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 17:08 Btrfs: check for empty bitmap list in setup_cluster_bitmaps Chris Mason
2015-12-15 18:37 ` Josef Bacik
2015-12-15 19:59   ` Chris Mason
2015-12-16  1:48 ` Manish [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20151216T024617-945@post.gmane.org \
    --to=coderinme@outlook.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox