public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION
Date: Thu, 23 Apr 2009 10:00:55 -0400	[thread overview]
Message-ID: <m3vdovo4fc.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <20090417083741.GA14933@lst.de> (Christoph Hellwig's message of "Fri, 17 Apr 2009 10:37:41 +0200")

Hi Christoph,

   > Add support for the standard attributes set via chattr and read
   > vis lsattr.  Currently we store the attributes in the flags value
   > in the btrfs inode, but I wonder whether we should split it into
   > two so that we don't have to keep converting between the two
   > formats.

Any thoughts on how best to add support for setting the custom btrfs
flags (nodatasum/nodatacow/nocompress) via an ioctl?  Is it possible
to reuse FS_IOC_SETFLAGS for these too, or do we need a new ioctl?
If we need a new one, any preference between an ioctl per flag vs.
a single ioctl that accepts a new set of flags?

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>

  parent reply	other threads:[~2009-04-23 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17  8:37 [PATCH] btrfs: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION Christoph Hellwig
2009-04-17 10:11 ` Edward Shishkin
2009-04-20 15:47   ` Christoph Hellwig
2009-04-21 21:30     ` Edward Shishkin
2009-04-23 14:00 ` Chris Ball [this message]
2009-04-23 18:01   ` Christoph Hellwig
2009-04-23 19:56 ` Chris Mason
2009-04-25 19:13 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vdovo4fc.fsf@pullcord.laptop.org \
    --to=cjb@laptop.org \
    --cc=hch@lst.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox