From: Su Yue <l@damenly.su>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: make btrfs_node_key static inline
Date: Tue, 14 Sep 2021 22:08:36 +0800 [thread overview]
Message-ID: <mtof1bt2.fsf@damenly.su> (raw)
In-Reply-To: <20210914131253.GA9286@twin.jikos.cz>
On Tue 14 Sep 2021 at 15:12, David Sterba <dsterba@suse.cz> wrote:
> On Tue, Sep 14, 2021 at 06:53:35PM +0800, Su Yue wrote:
>> It looks strange that btrfs_node_key is in struct-funcs.c.
>> So move it to ctree.h and make it static inline.
>
> "looks strange" is not a sufficient reason. Inlining a function
> means
> that the body will be expanded at each call site, bloating the
> binary
> code. Have you measured the impact of that?
>
Fair enough.
Before:
text data bss dec hex filename
1202418 123105 19384 1344907 14858b fs/btrfs/btrfs.ko
After:
text data bss dec hex filename
1202620 123105 19384 1345109 148655 fs/btrfs/btrfs.ko
+202
> There's some performance cost of an non-inline function due to
> the call
> overhead but it does not make sense to inline a function that's
> called
> rarely and not in a tight loop. If you grep for the function
> you'd see
> that it's called eg. once per function or in a loop that's not
> performance critical on first sight (eg. in reada_for_search).
Right, the patch won't impact performance obviously at the cost of
+202 binary size. So I'd drop the patch.
Sorry for the noise.
--
Su
next prev parent reply other threads:[~2021-09-14 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 10:53 [PATCH] btrfs: make btrfs_node_key static inline Su Yue
2021-09-14 13:12 ` David Sterba
2021-09-14 14:08 ` Su Yue [this message]
2021-09-14 14:36 ` David Sterba
2021-09-14 14:55 ` Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mtof1bt2.fsf@damenly.su \
--to=l@damenly.su \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox