linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: Format change for btrfs fi df
Date: Tue, 12 Jan 2016 00:20:09 +0000 (UTC)	[thread overview]
Message-ID: <pan$32077$664eed64$6034389c$264c6b0d@cox.net> (raw)
In-Reply-To: 20160111155108.GH4227@twin.jikos.cz

David Sterba posted on Mon, 11 Jan 2016 16:51:08 +0100 as excerpted:

> Hi
> 
> On Tue, Jan 05, 2016 at 10:01:08AM +0800, Qu Wenruo wrote:
>> Would you please consider merge this patch?
>> 
>> As current output is already quite confusing for a lot of users who are
>> not familiar with btrfs.
> 
> I understand it's confusing but as there's some history behind this
> option I need to think about the consequences. I'd rather keep it in the
> output, removing stuff is likely to cause breakage in scripts etc. OTOH,
> the 'fi df' was supposed to be a debugging helper but not everybody is
> used to 'fi usage' yet.

Not only is not everybody used to btrfs fi usage yet, but because it's 
still broken in various cases as well as relatively new, btrfs fi df 
along with btrfs fi sh remains the recommended way of getting that 
information.

Of course we can't go back in time to introduce btrfs fi usage earlier, 
but the sooner it works on all btrfs, including mixed-mode, which I know 
it doesn't properly support yet, and raid56, which IIRC it didn't support 
but I can't directly test, without producing weird EiB readings, the 
sooner we'll be able to generally recommend it except for people using 
what will eventually be very old tools, where the first recommendation is 
to upgrade in any case.

But for now, because fi usage doesn't work in a significant number of 
cases, recommending that people use and post fi df and fi sh remains the 
easiest way to dependably get the needed information, without going off 
into paragraphs of exception explanation.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


  reply	other threads:[~2016-01-12  0:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-14  5:19 [PATCH] btrfs-progs: Format change for btrfs fi df Qu Wenruo
2016-01-05  2:01 ` Qu Wenruo
2016-01-11 15:51   ` David Sterba
2016-01-12  0:20     ` Duncan [this message]
2016-01-12 14:28 ` David Sterba
2016-01-12 19:55   ` Goffredo Baroncelli
2016-01-13  0:37     ` Qu Wenruo
2016-01-12 20:46   ` Henk Slager
2016-01-13  0:35   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$32077$664eed64$6034389c$264c6b0d@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).