From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: Problem with unmountable filesystem.
Date: Wed, 17 Sep 2014 20:22:17 +0000 (UTC) [thread overview]
Message-ID: <pan$529ae$2bc50fa8$5e7f68de$70f24efb@cox.net> (raw)
In-Reply-To: 54196F42.4030101@gmail.com
Austin S Hemmelgarn posted on Wed, 17 Sep 2014 07:23:46 -0400 as
excerpted:
> I've also discovered, when trying to use btrfs restore to copy out the
> data to a different system, that 3.14.1 restore apparently chokes on
> filesystem that have lzo compression turned on. It's reporting errors
> trying to inflate compressed files, and I know for a fact that none of
> those files were even open, let alone being written to, when the system
> crashed. I don't know if this is a known bug or even if it is still the
> case with btrfs-progs 3.16, but I figured I'd comment about it because I
> haven't seen anything about it anywhere.
FWIW that's a known and recently patched issue. If you're still seeing
issues with it with btrfs-progs 3.16, report it, but 3.14.1 almost
certainly wouldn't have had the fix. (This is one related patch turned
up by a quick search; there may be others.)
* commit 93ebec96f2ae1d3276ebe89e2d6188f9b46692fb
| Author: Vincent Stehlé <vincent.stehle@laposte.net>
| Date: Wed Jun 18 18:51:19 2014 +0200
|
| btrfs-progs: restore: check lzo compress length
|
| When things go wrong for lzo-compressed btrfs, feeding
| lzo1x_decompress_safe() with corrupt data during restore
| can lead to crashes. Reduce the risk by adding
| a check on the input length.
|
| Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
| Signed-off-by: David Sterba <dsterba@suse.cz>
|
| cmds-restore.c | 6 ++++++
| 1 file changed, 6 insertions(+)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
next prev parent reply other threads:[~2014-09-17 20:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 14:40 Problem with unmountable filesystem Austin S Hemmelgarn
2014-09-16 20:57 ` Chris Murphy
2014-09-17 11:23 ` Austin S Hemmelgarn
2014-09-17 18:57 ` Chris Murphy
2014-09-17 20:07 ` Duncan
2014-09-18 17:12 ` Austin S Hemmelgarn
2014-09-18 21:15 ` Chris Murphy
2014-09-18 21:25 ` Duncan
2014-09-19 17:07 ` Chris Murphy
2014-09-19 17:42 ` Austin S Hemmelgarn
2014-09-17 20:22 ` Duncan [this message]
2014-09-18 17:19 ` Austin S Hemmelgarn
2014-09-19 17:54 ` Chris Murphy
2014-09-19 18:44 ` Austin S Hemmelgarn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$529ae$2bc50fa8$5e7f68de$70f24efb@cox.net' \
--to=1i5t5.duncan@cox.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).