From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command
Date: Fri, 4 Jul 2014 22:04:27 +0000 (UTC) [thread overview]
Message-ID: <pan$6f3ab$9b4cf7f$df6ad356$b0215b95@cox.net> (raw)
In-Reply-To: 20140704135226.GO1553@twin.jikos.cz
David Sterba posted on Fri, 04 Jul 2014 15:52:26 +0200 as excerpted:
> I disagree here, it's much more convenient to run 'fi df' anywhere and
> get the output. The system 'df' command works the same way.
Agreed.
I believe the proposed patch (at least based on its commit comment),
however, simply warns if the fi df is not done on a mount-point, giving
the mount-point that it's printing information for. IMO that /is/
helpful, and comparable to standard df, which has a mountpoint column, so
with the patch the same mount-point information is available from fi df
as from normal df, just a bit differently.
It wasn't quite clear from the discussion whether that would be the case,
and I was prepared to protest the patch if it wasn't, but the way things
turned out (based on the commit comment, I don't claim to read code)
seems fine to me.
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
next prev parent reply other threads:[~2014-07-04 22:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 8:38 [PATCH 1/2] btrfs-progs: Check fstype in find_mount_root() Qu Wenruo
2014-07-04 8:38 ` [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command Qu Wenruo
2014-07-04 13:52 ` David Sterba
2014-07-04 22:04 ` Duncan [this message]
2014-07-07 0:44 ` Qu Wenruo
2014-07-22 14:41 ` David Sterba
2014-07-07 9:51 ` Vikram Goyal
2014-07-08 1:19 ` Qu Wenruo
2014-07-07 15:45 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$6f3ab$9b4cf7f$df6ad356$b0215b95@cox.net' \
--to=1i5t5.duncan@cox.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).