Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: feature request: consider rw subvols ro for send when volume is mounted ro
Date: Thu, 24 Jul 2014 01:38:32 +0000 (UTC)	[thread overview]
Message-ID: <pan$9782b$83bda3f0$b4a4f489$5c1b675f@cox.net> (raw)
In-Reply-To: 20140723204736.GD17798@lenny.home.zabbo.net

Zach Brown posted on Wed, 23 Jul 2014 13:47:36 -0700 as excerpted:

> On Wed, Jul 23, 2014 at 02:10:29PM -0600, Chris Murphy wrote:
>> The use case is when it's possible to mount a Btrfs volume ro, but not
>> rw. Example, a situation where
>> 
>> # mount -o degraded /dev/sdb /mnt
>> [...] BTRFS: too many missing devices, writeable mount is not allowed 
>> 
>> Yet this works:
>> # mount -o degraded,ro /dev/sdb /mnt
>> 
>> It would be great if it were possible to send/receive subvolumes to a
>> different btrfs volume. Currently it's not possible because those
>> subvols aren't ro, and because the mount is ro I can't make ro
>> snapshots first.

In general, btrfs send/receive is great when it works, but because 
there's still corner-cases like this as well as simply broken send/
receive cases popping up from time to time, I strongly recommend not 
relying on it working, and keeping a more conventional backup option 
(like rsync) tested-working and usable as well.
 
> I wonder if that's as easy as the following totally untested hack.  I
> have no idea if a read-only mount would still allow background
> modification that might violate the send code's assumptions.

Hopefully that hack works.

Meanwhile, AFAIK, yes, there's still cases where a read-only mount can 
still allow background mods that would violate send's assumptions.  Tho I 
don't believe they apply in this case.  But certainly, there has been 
recent discussion on the subvolume mount situation, since it's possible 
to access child subvolumes from writable-mount parent (including root/
id5) subvolumes, and currently nothing stops writing into the read-only-
child's mount from the parent's writable mount.

Even without that situation, however, there's bind-mounts, which start 
out with the same mount options as the original, but with a remount allow 
one of the views to be read-only while the other is writable, regardless 
of the filesystem.  Obviously that allows changing the view on the read-
only side from the writable side.

So while having the ability to do a send from a read-only mount is indeed 
a good thing to have in emergency cases such as this, I'd suggest 
requiring a --force option or the like to enable it, since the full 
immutable-read-only guarantees simply aren't there.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


  reply	other threads:[~2014-07-24  1:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-23 20:10 feature request: consider rw subvols ro for send when volume is mounted ro Chris Murphy
2014-07-23 20:47 ` Zach Brown
2014-07-24  1:38   ` Duncan [this message]
2014-07-24 10:47   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$9782b$83bda3f0$b4a4f489$5c1b675f@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox