linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH ping] btrfs: warn about RAID5/6 being experimental at mount time
@ 2017-04-19 21:07 Adam Borowski
  2017-04-20 20:13 ` Duncan
  2017-04-26  2:14 ` Adam Borowski
  0 siblings, 2 replies; 7+ messages in thread
From: Adam Borowski @ 2017-04-19 21:07 UTC (permalink / raw)
  To: Chris Mason, Josef Bacik, David Sterba, linux-btrfs; +Cc: Adam Borowski

Too many people come complaining about losing their data -- and indeed,
there's no warning outside a wiki and the mailing list tribal knowledge.
Message severity chosen for consistency with XFS -- "alert" makes dmesg
produce nice red background which should get the point across.

Signed-off-by: Adam Borowski <kilobyte@angband.pl>
---
Resent alone, the other patch in the original series (dropping the incompat
flag when no longer needed) is pointless on its own.

I intend to ask for inclusion of this one (or an equivalent) in 4.9, either
in Debian or via GregKH -- while for us kernels "that old" are history,
regular users expect stable releases to be free of known serious data loss
bugs.


 fs/btrfs/disk-io.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index e54844767fe5..e7f91f70e149 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3083,6 +3083,14 @@ int open_ctree(struct super_block *sb,
 		btrfs_set_opt(fs_info->mount_opt, SSD);
 	}
 
+	if ((fs_info->avail_data_alloc_bits |
+	     fs_info->avail_metadata_alloc_bits |
+	     fs_info->avail_system_alloc_bits) &
+	    BTRFS_BLOCK_GROUP_RAID56_MASK) {
+		btrfs_alert(fs_info,
+		"btrfs RAID5/6 is EXPERIMENTAL and has known data-loss bugs");
+	}
+
 	/*
 	 * Mount does not set all options immediately, we can do it now and do
 	 * not have to wait for transaction commit
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-05-09 19:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-19 21:07 [PATCH ping] btrfs: warn about RAID5/6 being experimental at mount time Adam Borowski
2017-04-20 20:13 ` Duncan
2017-04-20 20:16   ` Sargun Dhillon
2017-04-26  2:14 ` Adam Borowski
2017-05-05 19:45   ` David Sterba
2017-05-09  1:49     ` Adam Borowski
2017-05-09 19:34       ` Goffredo Baroncelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).