From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: pass correct args to btrfs_async_run_delayed_refs()
Date: Tue, 18 Oct 2016 10:32:00 +0000 (UTC) [thread overview]
Message-ID: <pan$9e691$50b48431$37da74db$d7e3b0a2@applied-asynchrony.com> (raw)
In-Reply-To: 20161018075613.10757-1-wangxg.fnst@cn.fujitsu.com
On Tue, 18 Oct 2016 15:56:13 +0800, Wang Xiaoguang wrote:
> In btrfs_truncate_inode_items()->btrfs_async_run_delayed_refs(), we
> swap the arg2 and arg3 wrongly, fix this.
>
> Signed-off-by: Wang Xiaoguang <wangxg.fnst@cn.fujitsu.com>
> ---
> fs/btrfs/inode.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 2b790bd..2f1372b 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4605,8 +4605,8 @@ int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans,
> BUG_ON(ret);
> if (btrfs_should_throttle_delayed_refs(trans, root))
> btrfs_async_run_delayed_refs(root,
> - trans->transid,
> - trans->delayed_ref_updates * 2, 0);
> + trans->delayed_ref_updates * 2,
> + trans->transid, 0);
> if (be_nice) {
> if (truncate_space_check(trans, root,
> extent_num_bytes)) {
Reviewed-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Passing the wrong transid..why did this ever work?
-h
next prev parent reply other threads:[~2016-10-18 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 7:56 [PATCH] btrfs: pass correct args to btrfs_async_run_delayed_refs() Wang Xiaoguang
2016-10-18 10:32 ` Holger Hoffstätte [this message]
2016-10-19 4:57 ` Wang Xiaoguang
2016-10-19 14:02 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$9e691$50b48431$37da74db$d7e3b0a2@applied-asynchrony.com' \
--to=holger@applied-asynchrony.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).