linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: safe/necessary to balance system chunks?
Date: Fri, 25 Apr 2014 23:03:03 +0000 (UTC)	[thread overview]
Message-ID: <pan$a73aa$187744ee$76aa9d20$301f58e9@cox.net> (raw)
In-Reply-To: 535AA581.1080301@gmail.com

Austin S Hemmelgarn posted on Fri, 25 Apr 2014 14:12:17 -0400 as
excerpted:
>
> On 2014-04-25 13:24, Chris Murphy wrote:
>> 
>> On Apr 25, 2014, at 8:57 AM, Steve Leung <sjleung@shaw.ca> wrote:
>> 
>>> Assuming this is something that needs to be fixed, would I be able to
>>> fix this by balancing the system chunks?  Since the "force" flag is
>>> required, does that mean that balancing system chunks is inherently
>>> risky or unpleasant?
>> 
>> I don't think force is needed. You'd use btrfs balance start
>> -sconvert=raid1 <mountpoint>; or with -sconvert=raid1,soft although
>> it's probably a minor distinction for such a small amount of data.
> 
> The kernel won't allow a balance involving system chunks unless you
> specify force, as it considers any kind of balance using them to be
> dangerous.  Given your circumstances, I'd personally say that the safety
> provided by RAID1 outweighs the risk of making the FS un-mountable.

To clear this up, FWIW...

In a balance, metadata includes system by default.

If you go back and look at the committed balance filters patch, the 
wording on the -s/system chunks option is that it requires -f/force 
because one would normally handle system as part of metadata, not for any 
other reason.

What it looks like to me is that the original patch in progress may not 
have had -s/system as a separate filter at all, treating it as
-m/metadata, but perhaps someone suggested having -s/system as a separate 
option too, and the author agreed.  But since -m/metadata includes -s/
system by default, and that was the intended way of doing things,
-f/force was added as necessary when doing only -s/system, since 
presumably that was considered an artificial distinction, and handling -s/
system as a part of -m/metadata was considered the more natural method.

Which begs the question[1], is there a safety or procedural reason one 
should prefer handling metadata and system chunks at the same time, 
perhaps because rewriting the one involves rewriting critical bits of the 
other anyway, or is it simply that the author considered system a subset 
of metadata, anyway?  That I don't know.

But what I do know is that -f/force isn't required with -m/metadata, 
which includes -s/system by default anyway, so unless there's reason to 
treat the two differently, just use -m/metadata and let it handle -s/
system as well. =:^)

---
[1] Begs the question: Modern more natural/literal majority usage 
meaning: invites/forces the question, the question becomes so obvious 
that it's "begging" to be asked, at least in the speaker/author's (my) 
own head.  Yes, I am aware of but generally prefer "assumes and thus 
can't prove the postulate" or similar wording as an alternate to the 
translation-accident meaning.  If you have some time and are wondering 
what I'm talking about and/or think I used the term incorrectly, google 
it (using duck-duck-go or the like if you don't like google's profiling). 
=:^)

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


  parent reply	other threads:[~2014-04-25 23:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-25 14:57 safe/necessary to balance system chunks? Steve Leung
2014-04-25 17:24 ` Chris Murphy
2014-04-25 18:12   ` Austin S Hemmelgarn
2014-04-25 18:43     ` Steve Leung
2014-04-25 19:07       ` Austin S Hemmelgarn
2014-04-26  4:01         ` Duncan
2014-04-26  1:11       ` Duncan
2014-04-26  1:24       ` Chris Murphy
2014-04-26  2:56         ` Steve Leung
2014-04-26  4:05           ` Chris Murphy
2014-04-26  4:55           ` Duncan
2014-04-25 19:14     ` Hugo Mills
2014-06-19 11:32       ` Alex Lyakas
2014-04-25 23:03     ` Duncan [this message]
2014-04-26  1:41       ` Chris Murphy
2014-04-26  4:23         ` Duncan
2014-04-25 18:36   ` Steve Leung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$a73aa$187744ee$76aa9d20$301f58e9@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).