linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: missing /sbin/fsck.btrfs
Date: Tue, 26 Nov 2013 22:36:50 +0000 (UTC)	[thread overview]
Message-ID: <pan$bbb5d$b7661b1a$f706f6ee$1a74681f@cox.net> (raw)
In-Reply-To: A1C7FA8D-A87E-40CD-A887-84C147CA5C08@colorremedies.com

Chris Murphy posted on Tue, 26 Nov 2013 11:43:02 -0700 as excerpted:

> On Nov 26, 2013, at 12:18 AM, Duncan <1i5t5.duncan@cox.net> wrote:
>>> 
>> 
>> Just symlink/copy fsck.btrfs to (/bin/)true.
> 
> I'm not doing this every time I install an OS, most users won't
> either, and nor will most distributions. So in effect, this
> suggestion places the burden of implementation on the btrfs-progs
> package to create it at install time.

I think the "proper" solution is the one below.  This one is just a
workaround, to be done by the sysadmin if the distro or sysadmin
doesn't manage fstab properly.

>> https://btrfs.wiki.kernel.org/index.php/FAQ#What.27s_the_difference_between_btrfsck_and_fsck.btrfs
>> 
>> Or just do the /etc/fstab fs_passno = 0 thing, which is what I did
>> with reiserfs, so no change in that regard here when I switched to
>> btrfs for most partitions.
> 
> And that's fine, it places the burden on the distribution installer
> to create a correct /etc/fstab.

Distro installers should be creating a proper fstab anyway, and sysadmins
should catch it if they change things or if the installer doesn't get it,
because that's ultimately what sysadmins /do/, admin the system, including
setting up an appropriate fstab for their layout, and of course dealing
with distro bugs is a part of adminning a system as well.

And IMO, if an installer, human or automated distro install it doesn't
matter, sets up btrfs, setting anything but a zero/disabled fsck pass
number in fstab is almost certainly a mistake/bug, unless it's deliberately
set elsewise to cover some special case, in which case another step of
the same deliberate process should be symlinking fsck.btrfs to either
true or btrfsck as appropriate.  Because setting anything other that
a pass number of zero for btrfs by default should be exactly that,
a deliberate special-case, ideally documented as such in an fstab
comment and if automated as by an installer script, in that script
as well.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


  reply	other threads:[~2013-11-26 22:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-26  6:40 missing /sbin/fsck.btrfs Chris Murphy
2013-11-26  7:18 ` Duncan
2013-11-26  7:53   ` dima
2013-11-26 18:43   ` Chris Murphy
2013-11-26 22:36     ` Duncan [this message]
2013-11-27  4:55   ` Chris Murphy
2013-11-27  6:14     ` Duncan
2013-11-27  0:51 ` Dave Chinner
2013-11-27  3:06   ` Chris Murphy
2013-12-01 23:01     ` Dave Chinner
2013-12-30 17:18       ` Tom Gundersen
2014-01-06 14:55         ` Karel Zak
2013-11-27 11:19   ` Tom Gundersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='pan$bbb5d$b7661b1a$f706f6ee$1a74681f@cox.net' \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).