From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from plane.gmane.org ([80.91.229.3]:57162 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755305AbaFRVXJ (ORCPT ); Wed, 18 Jun 2014 17:23:09 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WxNJx-0008LR-Gk for linux-btrfs@vger.kernel.org; Wed, 18 Jun 2014 23:23:05 +0200 Received: from ip68-231-22-224.ph.ph.cox.net ([68.231.22.224]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 18 Jun 2014 23:23:05 +0200 Received: from 1i5t5.duncan by ip68-231-22-224.ph.ph.cox.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 18 Jun 2014 23:23:05 +0200 To: linux-btrfs@vger.kernel.org From: Duncan <1i5t5.duncan@cox.net> Subject: Re: frustrations with handling of crash reports Date: Wed, 18 Jun 2014 21:22:50 +0000 (UTC) Message-ID: References: <20140519134915.GA27432@merlins.org> <539FE03F.5030306@jp.fujitsu.com> <20140617145957.GH19071@merlins.org> <20140617182745.GO19071@merlins.org> <53A192B8.2040601@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-btrfs-owner@vger.kernel.org List-ID: Konstantinos Skarlatos posted on Wed, 18 Jun 2014 16:23:04 +0300 as excerpted: > I guess that btrfs developers have put these BUG_ONs so that they get > reports from users when btrfs gets in these unexpected situations. But > if most of these reports are ignored or not resolved, then maybe there > is no use for these BUG_ONs and they should be replaced with something > more mild. > > Keep in mind that if a system panics, then the only way to get logs from > it is with serial or netconsole, so BUG_ON really makes it much harder > for users to know what happened and send reports, and only the most > technical and determined users will manage to send reports here. In terms of the BUGONs, they've been converting them to WARNONs recently, exactly due to the point you and Marc have made. Not being a dev and simply based on the patch-flow I've seen as btrfs has been basically behaving itself so far here[1], I had /thought/ that was more or less done (perhaps some really bad bug-ons left but only a few, and basically only where the kernel couldn't be sure it was in a logical enough state to continue writing to other filesystems too, so bugon being logical in that case), but based on you guys' comments there's apparently more to go. So at least for BUGONs they agree. I guess it's simply a matter of getting them all converted. Tho at least in Marc's case, he's running kernels a couple back in some cases and they may still have BUGONs already replaced in the most current kernel. As for experimental, they've been toning down and removing the warnings recently. Yes, the on-device format may come with some level of compatibility guarantee now so I do agree with that bit, but IMO anyway, that warning should be being replaced with a more explicit "on-device- format is now stable but the code is not yet entirely so, so keep your backups and be prepared to use them, and run current kernels", language, and that's not happening, they're mostly just toning it down without the still explicit warnings, ATM. --- [1] Btrfs (so far) behaving itself here: Possibly because my filesystems are relatively small and I don't use snapshots much and prefer several smaller independent filesystems rather than doing subvolumes, thus keeping the number of eggs in a single basket small. Plus, with small filesystems on SSD, I can balance reasonably regularly, and I do full fresh mkfs.btrfs rounds every few kernels as well to take advantage of newer features, which may well have the result of killing smaller problems that aren't yet showing up before they get big enough to cause real issues. Anyway, I'm not complaining! =:^) -- Duncan - List replies preferred. No HTML msgs. "Every nonfree program has a lord, a master -- and if you use the program, he is your master." Richard Stallman