From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: btrfs receive leaves new subvolume modifiable during operation
Date: Fri, 3 Feb 2017 09:14:59 +0000 (UTC) [thread overview]
Message-ID: <pan$e2f8a$ba778439$cd53e97c$382283f9@cox.net> (raw)
In-Reply-To: 1b69d1a8-c08b-c9f3-c95b-1d7d71c7d642@cobb.uk.net
Graham Cobb posted on Thu, 02 Feb 2017 10:52:26 +0000 as excerpted:
> On 02/02/17 00:02, Duncan wrote:
>> If it's a workaround, then many of the Linux procedures we as admins
>> and users use every day are equally workarounds. Setting 007 perms on
>> a dir that doesn't have anything immediately security vulnerable in it,
>> simply to keep other users from even potentially seeing or being able
>> to write to something N layers down the subdir tree, is standard
>> practice.
>
> No. There is no need to normally place a read-only snapshot below a
> no-execute directory just to prevent write access to it. That is not
> part of the admin's expectation.
>
>> Which is my point. This is no different than standard security
>> practice,
>> that an admin should be familiar with and using without even having to
>> think about it. Btrfs is simply making the same assumptions that
>> everyone else does, that an admin knows what they are doing and sets
>> the upstream permissions with that in mind. If they don't, how is that
>> btrfs' fault?
>
> Because btrfs intends the receive snapshot to be read-only. That is the
> expectation of the sysadmin.
Read-only *after* completion, yes. But a sysadmin that believes really
setting something read-only and then trying to write to it from
userspace, which is what btrfs does until the receive is done, should
work, doesn't understand the meaning of read-only.
Meanwhile, Austin said most of what I'd say, probably better than I'd say
it, so I won't repeat it here, but I agree with him.
> Even though it is security-related, I agree it isn't the highest
> priority btrfs bug. It can probably wait until receive is being worked
> on for other reasons. But if it isn't going to be fixed any time soon,
> it should be documented in the Wiki and the man page, with the suggested
> workround for anyone who needs to make sure the receive won't be
> tampered with.
One thing I was going to say in the previous post and forgot, is that not
withstanding all the technical reasons, I do agree that documenting it in
the manpage, etc, would be a good idea. In that I agree with both you
and Austin. =:^)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
next prev parent reply other threads:[~2017-02-03 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 23:32 btrfs receive leaves new subvolume modifiable during operation Christian Lupien
2017-02-01 5:09 ` Duncan
2017-02-01 12:28 ` Austin S. Hemmelgarn
2017-02-01 17:43 ` Graham Cobb
2017-02-01 22:27 ` Duncan
2017-02-01 22:51 ` Graham Cobb
2017-02-02 0:02 ` Duncan
2017-02-02 10:52 ` Graham Cobb
2017-02-02 12:49 ` Austin S. Hemmelgarn
2017-02-03 9:14 ` Duncan [this message]
2017-02-03 12:44 ` Austin S. Hemmelgarn
2017-02-03 15:44 ` Graham Cobb
2017-02-03 16:01 ` Austin S. Hemmelgarn
2017-02-03 19:17 ` Graham Cobb
2017-02-03 19:37 ` Austin S. Hemmelgarn
2017-02-05 12:08 ` Kai Krakow
2017-02-06 22:56 ` Graham Cobb
2017-02-05 11:54 ` Kai Krakow
2017-02-06 12:30 ` Austin S. Hemmelgarn
2017-02-06 21:40 ` Kai Krakow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='pan$e2f8a$ba778439$cd53e97c$382283f9@cox.net' \
--to=1i5t5.duncan@cox.net \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).