linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Duncan <1i5t5.duncan@cox.net>
To: linux-btrfs@vger.kernel.org
Subject: Re: btrfs: block rsv returned -28
Date: Sat, 25 Feb 2012 04:55:45 +0000 (UTC)	[thread overview]
Message-ID: <pan.2012.02.25.04.55.45@cox.net> (raw)
In-Reply-To: 4F484BB8.2090601@polymtl.ca

Christian Robert posted on Fri, 24 Feb 2012 21:47:20 -0500 as excerpted:

> wrong, I tryed to wait until "Load average" got near to zero (couple of
> minutes)
> before unmounting and it changed nothing. None of thoses subvolumes have
> any data inside so deleting should be trivial and quick.
> 
> Got the kernel backtrace "while" doing the deletes. Not after.

Please don't top post.  It makes replying in context nearly impossible.  
Here, I quote your reply, but the context in which it was made gets lost 
because you top-posted instead of replying inline, at the appropriate 
place based on context, or bottom-posting if it's not /too/ long (it 
isn't, bottom posting would have been fine, in this case) and you can't 
be bothered to trim to context appropriately.

cwillu is correct.  The subvolume deletes do happen in the background and 
it can delay unmounting, in cases like this 10K subvolumes scenario, 
significantly.  There was some discussion of that recently on another 
thread, along with a patch so the unmounting is allowed (for shutdown, 
etc) and the cleanup picked up again after remounting,  But it was recent 
enough the patch will have only just made it into 3.3-prerelease kernel 
mainline (probably with Chris's pull request to Linus from less than 12 
hours ago, as CCed to this list, I'm not sure Linus has actually pulled 
it yet), or may be delayed until the 3.4 commit window.

Never-the-less, you have a point about the backtraces happening while 
doing the deletes.  That's a problem that the allow unmount and finish 
cleanup later patch wouldn't have addressed by itself, but it's possible 
other recent patches address it (especially since the pull includes a lot 
of fixes based on Oracle's current intensive btrfs internal QA testing), 
so I'd suggest doing a git pull in a few hours, checking that Linus has 
applied Chris's pull request (this assumes you're running mainline 
kernel, of course), and after that's applied and you're running the new 
kernel with it, rerunning your test.  If it still backtraces at that 
point then yeah, it's worth further investigation.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman


  reply	other threads:[~2012-02-25  4:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-25  2:26 btrfs: block rsv returned -28 Christian Robert
2012-02-25  2:37 ` cwillu
2012-02-25  2:47   ` Christian Robert
2012-02-25  4:55     ` Duncan [this message]
2012-02-25  4:31 ` Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2012.02.25.04.55.45@cox.net \
    --to=1i5t5.duncan@cox.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).