From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: dsterba@suse.cz
Cc: Martin Steigerwald <Martin@lichtvoll.de>,
linux-btrfs@vger.kernel.org,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH] btrfs-progs: mkfs: allow not to trim a device
Date: Tue, 20 Mar 2012 09:30:43 -0400 [thread overview]
Message-ID: <yq17gyf1jss.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20120320101641.GM32563@ds.suse.cz> (David Sterba's message of "Tue, 20 Mar 2012 11:16:41 +0100")
>>>>> "David" == David Sterba <dsterba@suse.cz> writes:
>> Just curious: Whats the use case for this?
David> http://digitalvampire.org/blog/index.php/2012/03/16/you-can-never-be-too-rich-or-too-thin/
Well, a cap of 1MB per UNMAP command is absolute crazy talk. We
currently do 2GB per command on ATA and 2TB per command on most SCSI
targets.
I don't disagree that it may make sense to have a disable discard option
to mkfs. But Roland really needs to get his VPD reporting fixed. I
suspect what the array meant to communicate was a 1MB discard
granularity, not a 1MB per command limit...a common mistake.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2012-03-20 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-17 18:51 [PATCH] btrfs-progs: mkfs: allow not to trim a device David Sterba
2012-03-19 17:24 ` Martin Steigerwald
2012-03-20 10:16 ` David Sterba
2012-03-20 13:30 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17gyf1jss.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=Martin@lichtvoll.de \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox