[PATCH v3 00/16] Converge on using secs_to_jiffies() part two

Easwar Hariharan
2025-02-25T20:17:20Z

This is the second series (part 1*) that converts users of msecs_to_jiffies() that
either use the multiply pattern of either of:
- msecs_to_jiffies(N*1000) or
- msecs_to_jiffies(N*MSEC_PER_SEC)

where N is a constant or an expression, to avoid the multiplication.

The conversion is made with Coccinelle with the secs_to_jiffies() script
in scripts/coccinelle/misc. Attention is paid to what the best change
can be rather than restricting to what the tool provides.

Andrew has kindly agreed to take the series through mm.git modulo the
patches maintainers want to pick through their own trees.

This series is based on next-20250225

Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>

* https://lore.kernel.org/all/20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com/

---
Changes in v3:
- Change commit message prefix from libata: zpodd to ata: libata-zpodd: in patch 8 (Damien)
- Split up overly long line in patch 9 (Christoph)
- Fixup unnecessary line break in patch 14 (Ilpo)
- Combine v1 and v2
- Fix some additional hunks in patch 2 (scsi: lpfc) which the more concise script missed
- msecs_to_jiffies -> msecs_to_jiffies() in commit messages throughout
- Bug in secs_to_jiffies() uncovered by LKP merged in 6.14-rc2: bb2784d9ab4958 ("jiffies: Cast to unsigned long in secs_to_jiffies() conversion")
- Link to v2: https://lore.kernel.org/r/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com

Changes in v2:
- Remove unneeded range checks in rbd and libceph. While there, convert some timeouts that should have been fixed in part 1. (Ilya)
- Fixup secs_to_jiffies.cocci to be a bit more verbose
- Link to v1: https://lore.kernel.org/r/20250128-converge-secs-to-jiffies-part-two-v1-0-9a6ecf0b2308@linux.microsoft.com

---
Easwar Hariharan (16):
coccinelle: misc: secs_to_jiffies: Patch expressions too
scsi: lpfc: convert timeouts to secs_to_jiffies()
accel/habanalabs: convert timeouts to secs_to_jiffies()
ALSA: ac97: convert timeouts to secs_to_jiffies()
btrfs: convert timeouts to secs_to_jiffies()
rbd: convert timeouts to secs_to_jiffies()
libceph: convert timeouts to secs_to_jiffies()
ata: libata-zpodd: convert timeouts to secs_to_jiffies()
xfs: convert timeouts to secs_to_jiffies()
power: supply: da9030: convert timeouts to secs_to_jiffies()
nvme: convert timeouts to secs_to_jiffies()
spi: spi-fsl-lpspi: convert timeouts to secs_to_jiffies()
spi: spi-imx: convert timeouts to secs_to_jiffies()
platform/x86/amd/pmf: convert timeouts to secs_to_jiffies()
platform/x86: thinkpad_acpi: convert timeouts to secs_to_jiffies()
RDMA/bnxt_re: convert timeouts to secs_to_jiffies()

.../accel/habanalabs/common/command_submission.c | 2 +-
drivers/accel/habanalabs/common/debugfs.c | 2 +-
drivers/accel/habanalabs/common/device.c | 2 +-
drivers/accel/habanalabs/common/habanalabs_drv.c | 2 +-
drivers/ata/libata-zpodd.c | 3 +-
drivers/block/rbd.c | 8 ++---
drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 2 +-
drivers/nvme/host/core.c | 6 ++--
drivers/platform/x86/amd/pmf/acpi.c | 2 +-
drivers/platform/x86/thinkpad_acpi.c | 2 +-
drivers/power/supply/da9030_battery.c | 3 +-
drivers/scsi/lpfc/lpfc.h | 3 +-
drivers/scsi/lpfc/lpfc_els.c | 11 +++---
drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +-
drivers/scsi/lpfc/lpfc_init.c | 10 +++---
drivers/scsi/lpfc/lpfc_scsi.c | 12 +++----
drivers/scsi/lpfc/lpfc_sli.c | 41 +++++++++-------------
drivers/scsi/lpfc/lpfc_vport.c | 2 +-
drivers/spi/spi-fsl-lpspi.c | 2 +-
drivers/spi/spi-imx.c | 2 +-
fs/btrfs/disk-io.c | 6 ++--
fs/xfs/xfs_icache.c | 2 +-
fs/xfs/xfs_sysfs.c | 8 ++---
include/linux/ceph/libceph.h | 12 +++----
net/ceph/ceph_common.c | 18 ++++------
net/ceph/osd_client.c | 3 +-
scripts/coccinelle/misc/secs_to_jiffies.cocci | 10 ++++++
sound/pci/ac97/ac97_codec.c | 3 +-
28 files changed, 82 insertions(+), 99 deletions(-)
---
base-commit: 0226d0ce98a477937ed295fb7df4cc30b46fc304
change-id: 20241217-converge-secs-to-jiffies-part-two-f44017aa6f67

Best regards,
--
Easwar Hariharan <eahariha@linux.microsoft.com>