From: Glynn Clements <glynn@gclements.plus.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: C programming list <linux-c-programming@vger.kernel.org>
Subject: Re: library routine wrappers and serious overkill
Date: Mon, 6 Jun 2005 02:13:03 +0100 [thread overview]
Message-ID: <17059.41759.788362.757952@gargle.gargle.HOWL> (raw)
In-Reply-To: <Pine.LNX.4.61.0506051727540.5731@localhost.localdomain>
Robert P. J. Day wrote:
> now, i'm as big a fan as the next guy of good debugging (the
> my_CONDITION macro is a local implementation of assert() with hooks to
> a logging library -- yeesh) but, seriously, there has to be a limit to
> just how much debugging you're going to apply to each and every
> string-related library routine. it does get kind of absurd after a
> while:
>
> ===============================
>
> char
> my_str_ch2upper(char const ch)
> {
> DBUG_ENTER(__FUNCTION__);
>
> if (isascii(ch) && islower(ch)) {
> DBUG_RETURN(toupper(ch));
> }
> DBUG_RETURN(ch);
> }
>
>
> ===============================
>
> is this what you'd call best practice?
It may be that the code was written for a platform which lacked a
working debugger, so the program had to be able to generate its own
stack traces etc.
--
Glynn Clements <glynn@gclements.plus.com>
next prev parent reply other threads:[~2005-06-06 1:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-05 21:34 library routine wrappers and serious overkill Robert P. J. Day
2005-06-06 1:13 ` Glynn Clements [this message]
2005-06-06 21:29 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17059.41759.788362.757952@gargle.gargle.HOWL \
--to=glynn@gclements.plus.com \
--cc=linux-c-programming@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).