Re: writing logfile

[Mat Harris <mat.harris@genestate.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1487 bytes --]

ok i have modified it to use open, write, and close> Now tho I am getting
garbage written to the logfile. Evidently i have made an error with types
or there is confusion between writing a text string and writing raw bits.

i have attached the modified code.

Thanks for all your help so far people :)

On Wed, Feb 26, 2003 at 01:09:12 +0000, Glynn Clements wrote:
> 
> Mat Harris wrote:
> 
> >   loghandle = open(logfile, O_CREAT);
> 
> This should probably be:
> 
>    loghandle = open(logfile, O_WRONLY | O_CREAT | O_APPEND, 0600);
> 
> You may also wish to use the O_SYNC flag, to force data to be written
> to disk immediately (so that it isn't lost if the system crashes or
> the power fails).
> 
> As William pointed out, if you open the file with open(), you need to
> use write() to write data to the file. Alternatively, you could use
> fopen() and fputs(), but fopen() doesn't give you as much control
> (e.g. you can't set the permissions or the O_SYNC flag on creation).
> 
> Also, you can create an ANSI stream (a "FILE *") from a descriptor
> using fdopen(), and you can get the descriptor for an ANSI stream
> using fileno(). But you need to be careful about accessing a file
> using both methods (which basically means that you need to understand
> how the two relate to each other).
> 
> -- 
> Glynn Clements <glynn.clements@virgin.net>

-- 
Mat Harris			OpenGPG Public Key ID: C37D57D9
mat.harris@genestate.com	www.genestate.com	

[-- Attachment #1.2: log.h --]
[-- Type: text/plain, Size: 552 bytes --]

int open_log()
{
  char logfile[4096];
  int loghandle;

  strcpy(logfile, WEBROOT);
  strcat(logfile, "/logs/access.log");

  loghandle = open(logfile, O_WRONLY | O_CREAT | O_APPEND | O_SYNC, 0600);

  if (loghandle < 0)
    {
      fprintf(stderr, "Couldn't open logfile: %s\n", logfile);
      exit(1);
    }
  else
    {
      return loghandle;
    }
}

void close_log(int loghandle)
{
  close(loghandle);
}

void write_log(int loghandle, char string[1024])
{
  printf("requested file: %s\n", string);
  write(loghandle, string, sizeof(string));
}

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]