Re: writing logfile

[Jan-Benedict Glaw <jbglaw@lug-owl.de>]

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

On Wed, 2003-02-26 09:25:02 +0000, Mat Harris <mat.harris@genestate.com>
wrote in message <20030226092502.A12697@genestate.com>:
> ok i have modified it to use open, write, and close> Now tho I am getting
> garbage written to the logfile. Evidently i have made an error with types
> or there is confusion between writing a text string and writing raw bits.

Despite some other shortages, try it this way:

> On Wed, Feb 26, 2003 at 01:09:12 +0000, Glynn Clements wrote:
> int open_log()
> {
>   char logfile[4096];
>   int loghandle;
> 
>   strcpy(logfile, WEBROOT);
>   strcat(logfile, "/logs/access.log");

logfile *may* be too short. This is asking for trouble!

>   loghandle = open(logfile, O_WRONLY | O_CREAT | O_APPEND | O_SYNC, 0600);
> 
>   if (loghandle < 0)
>     {
>       fprintf(stderr, "Couldn't open logfile: %s\n", logfile);
>       exit(1);
>     }
>   else
>     {
>       return loghandle;
>     }
> }
> 
> void close_log(int loghandle)
> {
>   close(loghandle);
> }
> 
> void write_log(int loghandle, char string[1024])

void
write_log(int loghandle, char *string)

> {

if(!string)
	return;

>   printf("requested file: %s\n", string);
>   write(loghandle, string, sizeof(string));
	write(loghandle, string, strlen(string));
	write(loghandle, "\n", strlen("\n"));
> }

MfG, JBG

-- 
   Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
   "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
    fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
       ret = do_actions((curr | FREE_SPEECH) && ~(IRAQ_WAR_2 | DRM | TCPA);

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]