Re: writing logfile

[Mat Harris <mat.harris@genestate.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2429 bytes --]

ok and now i am getting something weird. when I try to log a successful
request, and then make the request again, it ands to the previous printf
message and prints it again so it repeats all the previous messages again
and again. Also, the garbage in the logfile is the beginning of my webroot
"/home....". I do not know what is going on here.

I have attached all my work so far. PS Please don't tell me about re-inventing
the wheel, this is just for experimentation :)

On Wed, Feb 26, 2003 at 11:09:15 +0100, Jan-Benedict Glaw wrote:
> On Wed, 2003-02-26 09:25:02 +0000, Mat Harris <mat.harris@genestate.com>
> wrote in message <20030226092502.A12697@genestate.com>:
> > ok i have modified it to use open, write, and close> Now tho I am getting
> > garbage written to the logfile. Evidently i have made an error with types
> > or there is confusion between writing a text string and writing raw bits.
> 
> Despite some other shortages, try it this way:
> 
> > On Wed, Feb 26, 2003 at 01:09:12 +0000, Glynn Clements wrote:
> > int open_log()
> > {
> >   char logfile[4096];
> >   int loghandle;
> > 
> >   strcpy(logfile, WEBROOT);
> >   strcat(logfile, "/logs/access.log");
> 
> logfile *may* be too short. This is asking for trouble!
> 
> >   loghandle = open(logfile, O_WRONLY | O_CREAT | O_APPEND | O_SYNC, 0600);
> > 
> >   if (loghandle < 0)
> >     {
> >       fprintf(stderr, "Couldn't open logfile: %s\n", logfile);
> >       exit(1);
> >     }
> >   else
> >     {
> >       return loghandle;
> >     }
> > }
> > 
> > void close_log(int loghandle)
> > {
> >   close(loghandle);
> > }
> > 
> > void write_log(int loghandle, char string[1024])
> 
> void
> write_log(int loghandle, char *string)
> 
> > {
> 
> if(!string)
> 	return;
> 
> >   printf("requested file: %s\n", string);
> >   write(loghandle, string, sizeof(string));
> 	write(loghandle, string, strlen(string));
> 	write(loghandle, "\n", strlen("\n"));
> > }
> 
> MfG, JBG
> 
> -- 
>    Jan-Benedict Glaw       jbglaw@lug-owl.de    . +49-172-7608481
>    "Eine Freie Meinung in  einem Freien Kopf    | Gegen Zensur | Gegen Krieg
>     fuer einen Freien Staat voll Freier Bürger" | im Internet! |   im Irak!
>        ret = do_actions((curr | FREE_SPEECH) && ~(IRAQ_WAR_2 | DRM | TCPA);



-- 
Mat Harris			OpenGPG Public Key ID: C37D57D9
mat.harris@genestate.com	www.genestate.com	

[-- Attachment #1.2: webserver.tar.gz --]
[-- Type: application/x-gzip, Size: 15524 bytes --]

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]