Re: writing logfile

[Mat Harris <mat.harris@genestate.com>]

[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]

ok, thanks guys for the help with my webserver, the loggin works fine and now
I have remembered about extern void etc I have put the functions to compile
seperateley as suggested.

Just one more thing tho, the logmessage is getting printed to the client's
browser after any html content has been transferred and I can't see where it
is happening. I have put a tarball of the whole thing at

http://www.genestate.com/~matthewh/debug/

thanks again.

On Wed, Feb 26, 2003 at 07:45:07 +0000, Glynn Clements wrote:
> 
> Mat Harris wrote:
> 
> > ok and now i am getting something weird. when I try to log a successful
> > request, and then make the request again, it ands to the previous printf
> > message and prints it again so it repeats all the previous messages again
> > and again. Also, the garbage in the logfile is the beginning of my webroot
> > "/home....". I do not know what is going on here.
> 
> Line 52 of webserver.c:
> 
> >	  strcat(logmsg, filename);
> 
> should be
> 
> 	  strcpy(logmsg, filename);
> 
> Also:
> 
> > #include "log.h" /* logging functions */
> 
> Don't use #include for actual code. Put it in a separate .c file and
> compile it separately.
> 
> > void write_log(int loghandle, char *string)
> > {
> >   write(loghandle, string, sizeof(string));
> > }
> 
>    write(loghandle, string, strlen(string));
> 
> Applying sizeof() to a "char *" will return the size of the pointer
> (typically 4 on a 32-bit system, 8 on a 64-bit system), not the length
> of the string to which it points.
> 
> -- 
> Glynn Clements <glynn.clements@virgin.net>

-- 
Mat Harris			OpenGPG Public Key ID: C37D57D9
mat.harris@genestate.com	www.genestate.com	

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]