linux-c-programming.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrej Gelenberg <andrej.gelenberg@udo.edu>
To: ratheesh k <ratheesh.ksz@gmail.com>
Cc: linux-c-programming@vger.kernel.org
Subject: Re: float
Date: Tue, 11 Jan 2011 09:38:17 +0100	[thread overview]
Message-ID: <4D2C16F9.4050607@udo.edu> (raw)
In-Reply-To: <AANLkTikyOX3yeh4Xo5vrax651djd_rkQuPy_vm30AZhM@mail.gmail.com>

Hi,

you can not check if 2 float are equal, you should check if it in the range:

On 01/11/2011 08:38 AM, ratheesh k wrote:
> I could not understand  why it getting printed like this. Could any
> body tell me.
>
> #include<stdio.h>
>

#define ABS(x) ((x) < 0 ? -(x) : (x))
#define MAX(a, b) ((a) > (b) ? (a) : (b))
const float precision = 0.001f;

> int main()
> {
>          float f=0.0f;
>          int i;
>
>          for(i=0;i<10;i++)
>                  f = f + 0.1f;
>
            if ( ABS(f - 1.0f) < precision )
>                  printf("f is 1.0 \n");
>          else
>                  printf("f is NOT 1.0\n");
>
>          return 0;
> }

Here more to that topic: 
https://www.securecoding.cert.org/confluence/display/seccode/FLP35-C.+Take+granularity+into+account+when+comparing+floating+point+values

Here more about c pitfalls: 
https://www.securecoding.cert.org/confluence/display/seccode/CERT+C+Secure+Coding+Standard

Regards,
Andrej Gelenberg

  parent reply	other threads:[~2011-01-11  8:38 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11  7:38 float ratheesh k
2011-01-11  7:46 ` float Thomas Weber
2011-01-11  7:56   ` float Amit Virdi
2011-01-11  7:55 ` float Uriel Corfa
2011-01-11  8:01   ` float Thomas Weber
2011-01-11  8:34     ` float ratheesh k
2011-01-11  8:57       ` float Thomas Weber
2011-01-11  8:38 ` Andrej Gelenberg [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-01-08 16:30 float phoenixxz
2010-01-08  4:42 ` float Bryan Christ
2010-01-08 16:45   ` float Fawad Lateef
2010-01-08 16:40 ` float Nanakos Chrysostomos
2010-01-08 16:44 ` float Fawad Lateef
2010-01-08 16:47 ` float Nanakos Chrysostomos
2010-01-08 17:11   ` float Michal Nazarewicz
2010-01-08 17:19     ` float Nanakos Chrysostomos
2010-01-08 17:21     ` float Nanakos Chrysostomos
2010-01-08 17:43       ` float Michal Nazarewicz
2010-01-08 18:00 ` float andrej.gelenberg
2010-01-08 22:05 ` float Glynn Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2C16F9.4050607@udo.edu \
    --to=andrej.gelenberg@udo.edu \
    --cc=linux-c-programming@vger.kernel.org \
    --cc=ratheesh.ksz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).