linux-c-programming.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David Rientjes" <rientjes@google.com>
To: Scott <drmemory@3rivers.net>
Cc: "Robert P. J. Day" <rpjday@mindspring.com>,
	linux-c-programming@vger.kernel.org
Subject: Re: how to implement routines that return general strings?
Date: Thu, 10 Aug 2006 12:04:25 -0700	[thread overview]
Message-ID: <9ec263480608101204t848a37u3e515f6c485a32ce@mail.google.com> (raw)
In-Reply-To: <20060810171238.GC778@drmemory.local>

On 8/10/06, Scott <drmemory@3rivers.net> wrote:
> With the caveat that I haven't done any serious programming in C for
> many years:  As I recall, I always used a protocol halfway between
> these, as:
>
> char *func(size_t bufsiz)
> {
>         char *retval = malloc (bufsiz);
>         if (retval == NULL) return (NULL);
>         /* whatever */
>         return (retval);
> }
>

It looks like this would lead to memory leaks that would be difficult
to track down along a wide variety of code paths upon return.

I recommend the first style: int func(char *buf, size_t bufsize).  All
malloc and frees are then encouraged to sandwich this call.

David

  reply	other threads:[~2006-08-10 19:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10 14:10 how to implement routines that return general strings? Robert P. J. Day
2006-08-10 17:12 ` Scott
2006-08-10 19:04   ` David Rientjes [this message]
2006-08-11 20:06   ` Kelly Burkhart
2006-08-12  9:36     ` Robert P. J. Day
2006-08-14 18:15       ` Scott
2006-08-10 21:07 ` Glynn Clements
2006-08-11  7:03   ` Raseel Bhagat
2006-08-11 18:36     ` Shorty Porty
  -- strict thread matches above, loose matches on Subject: below --
2006-08-10 16:51 Khan, Ahmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ec263480608101204t848a37u3e515f6c485a32ce@mail.google.com \
    --to=rientjes@google.com \
    --cc=drmemory@3rivers.net \
    --cc=linux-c-programming@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).