Re: feof fails

["Charlie Gordon" <gmane@chqrlie.org>]

"Christian Stalp" <stalp@imbei.uni-mainz.de> wrote in message
news:B0003441729@hermes.imsd.uni-mainz.de...
Hello together,
I have a simple problem. I opened a file with fopen and read from the file
with:
  while ( !feof( infile ) )
 {
   fgets( buffer, BUFFER_SIZE, infile );
   new_number = atoi ( buffer );
.....

The end of file condition is detected when trying to read from the file and
failing.
Thus feof(infile)  doesn't return non zero until after fgets fails at least
once.
You should test fgets return value to detect end of file.
The reason the last number is read twice is that your particular
implementation of fgets doesn't modify buffer upon end of file, it just
returns NULL, which you don't check before parsing the contents of the
buffer.

try this:

while (fgets(buffer, BUFFER_SIZE, infile)) {
    new_number = atoi(buffer);
    ...
}

simpler and better !

Chqrlie.

PS: wether the file is terminated with a newline or not is irrelevant to
this question.