Linux CAN drivers development
 help / color / mirror / Atom feed
From: Maud Spierings <maudspierings@gocontroll.com>
To: peng.fan@nxp.com
Cc: a-govindraju@ti.com, conor+dt@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com, frank.li@nxp.com,
	haibo.chen@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de,
	kishon@kernel.org, krzk+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	mailhol.vincent@wanadoo.fr, mkl@pengutronix.de, robh@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org, vkoul@kernel.org
Subject: Re: [PATCH 2/6] phy: phy-can-transceiver: Add support for NXP TJA1051
Date: Fri, 22 Aug 2025 09:20:32 +0200	[thread overview]
Message-ID: <060439dd-3df8-4d0b-8957-83b75dc13537@gocontroll.com> (raw)
In-Reply-To: <20250822-can-v1-2-c075f702adea@nxp.com>

Hi Peng,

> The TJA1051 is a high-speed CAN transceiver which is a pin-compatible
> alternative for TI TCAN1043 with Sleep mode supported.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/phy/phy-can-transceiver.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
> index f59caff4b3d4c267feca4220bf1547b6fad08f95..b49371a1272cd8a25b5e2271586b756103c64f0a 100644
> --- a/drivers/phy/phy-can-transceiver.c
> +++ b/drivers/phy/phy-can-transceiver.c
> @@ -85,6 +85,10 @@ static const struct of_device_id can_transceiver_phy_ids[] = {
>  		.compatible = "ti,tcan1043",
>  		.data = &tcan1043_drvdata
>  	},
> +	{
> +		.compatible = "nxp,tja1051",
> +		.data = &tcan1043_drvdata
> +	},
>  	{
>  		.compatible = "nxp,tjr1443",
>  		.data = &tcan1043_drvdata
> 
> -- 
> 2.37.1

Isn't this unnecessary as it has the ti,tcan1043 fallback compatible in 
the bindings? I'm still learning a lot so I might be wrong.

Kind regards,
Maud

  reply	other threads:[~2025-08-22  7:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  4:05 [PATCH 0/6] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
2025-08-22  4:05 ` [PATCH 1/6] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA1051/1048 Peng Fan
2025-08-22 16:55   ` Conor Dooley
2025-08-22  4:05 ` [PATCH 2/6] phy: phy-can-transceiver: Add support for NXP TJA1051 Peng Fan
2025-08-22  7:20   ` Maud Spierings [this message]
2025-08-25  7:01     ` Peng Fan
2025-08-22  4:05 ` [PATCH 3/6] phy: phy-can-transceiver: Add dual channel support for TJA1048 Peng Fan
2025-10-02 16:24   ` ChaosEsque Team
2025-08-22  4:05 ` [PATCH 4/6] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply Peng Fan
2025-08-22  4:05 ` [PATCH 5/6] arm64: dts: imx8mp-evk: " Peng Fan
2025-08-22  4:05 ` [PATCH 6/6] arm64: dts: imx93-11x11-evk: " Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=060439dd-3df8-4d0b-8957-83b75dc13537@gocontroll.com \
    --to=maudspierings@gocontroll.com \
    --cc=a-govindraju@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frank.li@nxp.com \
    --cc=haibo.chen@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox