From: Patrik Flykt <patrik.flykt@linux.intel.com>
To: Dan Murphy <dmurphy@ti.com>, linux-can@vger.kernel.org
Cc: wg@grandegger.com, mkl@pengutronix.de, sriram.dash@samsung.com,
jarkko.nikula@intel.com
Subject: Re: [PATCH 1/1] NET: mcan: Move runtime PM enable/disable to m_can_platform
Date: Mon, 19 Oct 2020 18:01:55 +0300 [thread overview]
Message-ID: <06568201ce997c0950bb41864df4c6c98a06ec9e.camel@linux.intel.com> (raw)
In-Reply-To: <fa0a6baa-99b0-8ddd-69cd-07c267419bbb@ti.com>
On Tue, 2020-09-01 at 13:22 -0500, Dan Murphy wrote:
> Patrik
>
> On 8/25/20 5:17 AM, Patrik Flykt wrote:
> > This is a preparatory patch for upcoming PCI based M_CAN devices.
> > The current PM implementation would cause PCI based drivers to
> > enable PM twice, once when the pci device is added and a second
> > time in m_can_class_register(). This will cause 'Unbalanced
> > pm_runtime_enable!' to be logged, and is a situation that should
> > be avoided.
> >
> > Therefore, in anticipation of PCI devices, move PM enabling out
> > from M_CAN class registration to its currently only user, the
> > m_can_platform driver.
> Reviewed-by: Dan Murphy <dmurphy@ti.com>
Ping?
Can this patch be added as-is or should it be sent in the patch set
providing a PCI based M_CAN device?
Cheers,
Patrik
next prev parent reply other threads:[~2020-10-19 15:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 10:17 [PATCH 0/1] NET: mcan: Move runtime PM enable/disable to m_can_platform Patrik Flykt
2020-08-25 10:17 ` [PATCH 1/1] " Patrik Flykt
2020-09-01 18:22 ` Dan Murphy
2020-10-19 15:01 ` Patrik Flykt [this message]
2020-10-19 15:47 ` Marc Kleine-Budde
2020-10-23 11:58 ` Patrik Flykt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06568201ce997c0950bb41864df4c6c98a06ec9e.camel@linux.intel.com \
--to=patrik.flykt@linux.intel.com \
--cc=dmurphy@ti.com \
--cc=jarkko.nikula@intel.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox