From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 644621D5174; Thu, 25 Jun 2026 17:07:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782407252; cv=none; b=opFNlM5jM1VCSrHmeRnZnuEChiwpn/AQISjF0Lkt0EgVr+fqdPSM6G0xW9om3+rmAO0euAPmtxtqZP6cV05vMsYqvr1WYfiDHMGkzrjID5R1Wa33I+bsdkE4Y+/GE40mATYIsKXJmiNkbk07YJ9sA5JL8Pnrf8K5Ssg/q7kWg/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782407252; c=relaxed/simple; bh=dC+JBzxebaOXyA9OOvT2b33Z9C9XGKYBYzH60DJgZKU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QVzDo1xcyD0G1E1gBRwSfcWPE1rblISAf8PG0sdOcvb+mAtj0Dn/4HovDgEWjsmrA3nCEflSqQUojC+VxZwX97qdzhJcx/wwvrjVNt7WklfbEzOsOE79X7k+AqqWkcZSf3hN5Qh3z4K4lZy2D5jDt1l3r3Htay0FZVX84Jj+kQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kw783CVm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kw783CVm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C14DC1F000E9; Thu, 25 Jun 2026 17:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782407251; bh=YxAQYhRsry2MpZzvQqF03q8jbMwMkEhXrYA2x4B6dp8=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=kw783CVmu/bDPIDBgjXws/S8Ehevrn4DXVULURkR1+Zm3RvUzXOynx5v6vD9iRIA8 6ThIw4ygulv93EYm14Z5H60iW2t4gbFdK0NA+dDqMbNQ/tOLwsdzcw2jNHKh4XFLfn Ol6iYqKSgblZ0ZBZaalcOzd7dKGSIg0fwz20EHesuL9Y1AlglTZWEGmD9QS4Xdekx/ MVdMgDFUpcjgm9Tg357+I0YB3lQwyELlReU7+8FXMyoh+pUjl66U7plyAS9ljQrxnH IkmL3Z1OsNFOwL8lTCOvkx/ROwKcIyx7GS7BVtQnGNVUqXjKOpcazZOd+QyGQUu6b+ e0jySbZa7AbDw== Message-ID: <126053be-ecdc-44fe-9242-d4267d332683@kernel.org> Date: Thu, 25 Jun 2026 19:07:26 +0200 Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] can: rcar_canfd: Change the initializing flow for clocks and resets To: Biju , Marc Kleine-Budde , Geert Uytterhoeven , Magnus Damm , Philipp Zabel Cc: Tu Nguyen , Biju Das , Duy Nguyen , Lad Prabhakar , linux-can@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260625135216.130450-1-biju.das.jz@bp.renesas.com> From: Vincent Mailhol Content-Language: en-US Autocrypt: addr=mailhol@kernel.org; keydata= xjMEZluomRYJKwYBBAHaRw8BAQdAf+/PnQvy9LCWNSJLbhc+AOUsR2cNVonvxhDk/KcW7FvN JFZpbmNlbnQgTWFpbGhvbCA8bWFpbGhvbEBrZXJuZWwub3JnPsKZBBMWCgBBFiEE7Y9wBXTm fyDldOjiq1/riG27mcIFAmdfB/kCGwMFCQp/CJcFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQq1/riG27mcKBHgEAygbvORJOfMHGlq5lQhZkDnaUXbpZhxirxkAHwTypHr4A/joI 2wLjgTCm5I2Z3zB8hqJu+OeFPXZFWGTuk0e2wT4JzjgEZx4y8xIKKwYBBAGXVQEFAQEHQJrb YZzu0JG5w8gxE6EtQe6LmxKMqP6EyR33sA+BR9pLAwEIB8J+BBgWCgAmFiEE7Y9wBXTmfyDl dOjiq1/riG27mcIFAmceMvMCGwwFCQPCZwAACgkQq1/riG27mcJU7QEA+LmpFhfQ1aij/L8V zsZwr/S44HCzcz5+jkxnVVQ5LZ4BANOCpYEY+CYrld5XZvM8h2EntNnzxHHuhjfDOQ3MAkEK In-Reply-To: <20260625135216.130450-1-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/06/2026 at 15:51, Biju wrote: > From: Tu Nguyen > > Testing CANFD on RZ/G3E shows that many registers do not reset to their > initial values with the current flow of deasserting resets first and then > enabling clocks. > > Based on the HW manual, clocks should be supplied first and the > resets deasserted afterward. > > section 7.4.3 Procedure for Activating Modules: RZ/G2L > section 4.4.9.3 Procedure for Starting up Units: RZ/G3E > > So, update the order of the initializing flow for resets and clocks > to match the hardware manual, resetting all CANFD registers to their > initial values. Also update rcar_canfd_global_deinit() to assert > resets before disabling clocks, so the teardown path mirrors the new > init ordering. > > Fixes: 76e9353a80e9 ("can: rcar_canfd: Add support for RZ/G2L family") > Signed-off-by: Tu Nguyen > Signed-off-by: Biju Das Reviewed-by: Vincent Mailhol Yours sincerely, Vincent Mailhol