Re: [RFC PATCH 00/14] can: netlink: add CAN XL

[Oliver Hartkopp <socketcan@hartkopp.net>]

Hi Vincent,

On 11.11.24 16:32, Oliver Hartkopp wrote:

> No problem! I will give some feedback when I managed to integrate the 
> extended netlink API to my driver.

I managed to set up my CAN XL dev board with the latest Linux kernel 
(6.13 merge) and upgraded to Ubuntu 24.04 LTS.

Applying your RFC patches for the kernel and the iproute2 package 
(including the sed hack) works great.

While the xl transceiver switch and the and the PWM configuration (with 
3 values with 6 bit each) are still missing I tried your current code as-is.

# modprobe dummyxl
(created can0)

# ip link set can0 type can bitrate 500000 xbitrate 8000000 xl on 
dbitrate 4000000 fd on

# ip -det link show can0
7: can0: <NOARP> mtu 2060 qdisc noop state DOWN mode DEFAULT group 
default qlen 10
     link/can  promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
     can <FD,TDC-AUTO,XL> state STOPPED restart-ms 0

Should there be a XTDC-AUTO too?

	  bitrate 500000 sample-point 0.875
	  tq 12 prop-seg 69 phase-seg1 70 phase-seg2 20 sjw 10 brp 1
	  dummyxl nominal: tseg1 2..256 tseg2 2..128 sjw 1..128 brp 1..512 
brp_inc 1
	  dbitrate 4000000 dsample-point 0.750
	  dtq 12 dprop-seg 7 dphase-seg1 7 dphase-seg2 5 dsjw 2 dbrp 1
	  tdco 15 tdcf 0

Should the tdc* values be placed behind dbrp 1 without a line break?
The gso/gro stuff below also heavily exceeds the 80 columns. And it is 
more in the same shape like with the CAN CC settings.

	  dummyxl FD: dtseg1 2..256 dtseg2 2..128 dsjw 1..128 dbrp 1..512 
dbrp_inc 1
	  tdco 0..127 tdcf 0..127

same here

	  xbitrate 8000000 xsample-point 0.700
	  xtq 12 xprop-seg 3 xphase-seg1 3 xphase-seg2 3 xsjw 1 xbrp 1

xtdco/xtdcf missing here?

	  dummyxl XL: xtseg1 2..256 xtseg2 2..128 xsjw 1..128 xbrp 1..512 
xbrp_inc 1

xtdco/xtdcf missing here?

	  clock 80000000 numtxqueues 1 numrxqueues 1 gso_max_size 65536 
gso_max_segs 65535 tso_max_size 65536 tso_max_segs 65535 gro_max_size 
65536 gso_ipv4_max_size 65536 gro_ipv4_max_size 65536

Best regards,
Oliver