From: Andreas Larsson <andreas@gaisler.com>
To: linux-can@vger.kernel.org
Cc: software@gaisler.com
Subject: [PATCH] can: sja1000: Add support for listen-only mode and one-shot mode
Date: Mon, 17 Sep 2012 17:58:02 +0200 [thread overview]
Message-ID: <1347897482-26379-1-git-send-email-andreas@gaisler.com> (raw)
Packages that fails to be transmitted in one-shot mode are never the
less echoed back as sja1000 does not give any indication when a single
transmission has failed.
Signed-off-by: Andreas Larsson <andreas@gaisler.com>
---
drivers/net/can/sja1000/sja1000.c | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
index 4c4f33d..cc771d9 100644
--- a/drivers/net/can/sja1000/sja1000.c
+++ b/drivers/net/can/sja1000/sja1000.c
@@ -141,6 +141,7 @@ static void set_normal_mode(struct net_device *dev)
struct sja1000_priv *priv = netdev_priv(dev);
unsigned char status = priv->read_reg(priv, REG_MOD);
int i;
+ u8 normal = priv->can.ctrlmode & CAN_CTRLMODE_LISTENONLY ? MOD_LOM : 0;
for (i = 0; i < 100; i++) {
/* check reset bit */
@@ -156,7 +157,7 @@ static void set_normal_mode(struct net_device *dev)
}
/* set chip to normal mode */
- priv->write_reg(priv, REG_MOD, 0x00);
+ priv->write_reg(priv, REG_MOD, normal);
udelay(10);
status = priv->read_reg(priv, REG_MOD);
}
@@ -278,6 +279,7 @@ static netdev_tx_t sja1000_start_xmit(struct sk_buff *skb,
canid_t id;
uint8_t dreg;
int i;
+ u8 oneshot;
if (can_dropped_invalid_skb(dev, skb))
return NETDEV_TX_OK;
@@ -310,7 +312,8 @@ static netdev_tx_t sja1000_start_xmit(struct sk_buff *skb,
can_put_echo_skb(skb, dev, 0);
- sja1000_write_cmdreg(priv, CMD_TR);
+ oneshot = (priv->can.ctrlmode & CAN_CTRLMODE_ONE_SHOT) ? CMD_AT : 0;
+ sja1000_write_cmdreg(priv, CMD_TR | oneshot);
return NETDEV_TX_OK;
}
@@ -605,7 +608,8 @@ struct net_device *alloc_sja1000dev(int sizeof_priv)
priv->can.do_set_mode = sja1000_set_mode;
priv->can.do_get_berr_counter = sja1000_get_berr_counter;
priv->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
- CAN_CTRLMODE_BERR_REPORTING;
+ CAN_CTRLMODE_BERR_REPORTING | CAN_CTRLMODE_LISTENONLY |
+ CAN_CTRLMODE_ONE_SHOT;
spin_lock_init(&priv->cmdreg_lock);
--
1.7.0.4
next reply other threads:[~2012-09-17 17:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 15:58 Andreas Larsson [this message]
2012-09-18 13:46 ` [PATCH] can: sja1000: Add support for listen-only mode and one-shot mode Marc Kleine-Budde
2012-09-18 14:11 ` Wolfgang Grandegger
2012-09-18 15:54 ` Andreas Larsson
2012-09-18 16:16 ` Ira W. Snyder
2012-09-18 16:20 ` Marc Kleine-Budde
2012-09-18 16:34 ` [PATCH v2] " Andreas Larsson
2012-09-18 17:17 ` Marc Kleine-Budde
2012-09-18 17:23 ` Oliver Hartkopp
2012-09-19 5:55 ` Andreas Larsson
2012-09-18 18:27 ` Wolfgang Grandegger
2012-09-19 5:56 ` Andreas Larsson
2012-09-19 7:12 ` [PATCH v3] " Andreas Larsson
2012-09-19 7:33 ` Wolfgang Grandegger
2012-09-19 10:24 ` [PATCH v4] " Andreas Larsson
2012-09-19 16:49 ` Oliver Hartkopp
2012-09-20 7:50 ` [PATCH v5] " Andreas Larsson
2012-09-21 8:08 ` Marc Kleine-Budde
2012-09-21 8:12 ` Andreas Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347897482-26379-1-git-send-email-andreas@gaisler.com \
--to=andreas@gaisler.com \
--cc=linux-can@vger.kernel.org \
--cc=software@gaisler.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).