From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: Kurt Van Dijck <kurt.van.dijck@eia.be>,
Wolfgang Grandegger <wg@grandegger.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-kernel@vger.kernel.org,
Fabio Baltieri <fabio.baltieri@gmail.com>,
Anant Gole <anantgole@ti.com>
Subject: [PATCH 4/9] can: ti_hecc: add LED trigger support
Date: Sun, 16 Dec 2012 12:08:28 +0100 [thread overview]
Message-ID: <1355656113-9562-5-git-send-email-fabio.baltieri@gmail.com> (raw)
In-Reply-To: <1355656113-9562-1-git-send-email-fabio.baltieri@gmail.com>
Add support for canbus activity led indicators on ti_hecc devices by
calling appropriate can_led functions.
These are only enabled when CONFIG_CAN_LEDS is Y, becomes no-op
otherwise.
Cc: Anant Gole <anantgole@ti.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
---
drivers/net/can/ti_hecc.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/net/can/ti_hecc.c b/drivers/net/can/ti_hecc.c
index f898c63..f52a975 100644
--- a/drivers/net/can/ti_hecc.c
+++ b/drivers/net/can/ti_hecc.c
@@ -50,6 +50,7 @@
#include <linux/can/dev.h>
#include <linux/can/error.h>
+#include <linux/can/led.h>
#include <linux/can/platform/ti_hecc.h>
#define DRV_NAME "ti_hecc"
@@ -593,6 +594,7 @@ static int ti_hecc_rx_pkt(struct ti_hecc_priv *priv, int mbxno)
spin_unlock_irqrestore(&priv->mbx_lock, flags);
stats->rx_bytes += cf->can_dlc;
+ can_led_event(priv->ndev, CAN_LED_EVENT_RX);
netif_receive_skb(skb);
stats->rx_packets++;
@@ -796,6 +798,7 @@ static irqreturn_t ti_hecc_interrupt(int irq, void *dev_id)
stats->tx_bytes += hecc_read_mbx(priv, mbxno,
HECC_CANMCF) & 0xF;
stats->tx_packets++;
+ can_led_event(ndev, CAN_LED_EVENT_TX);
can_get_echo_skb(ndev, mbxno);
--priv->tx_tail;
}
@@ -851,6 +854,8 @@ static int ti_hecc_open(struct net_device *ndev)
return err;
}
+ can_led_event(ndev, CAN_LED_EVENT_OPEN);
+
ti_hecc_start(ndev);
napi_enable(&priv->napi);
netif_start_queue(ndev);
@@ -869,6 +874,8 @@ static int ti_hecc_close(struct net_device *ndev)
close_candev(ndev);
ti_hecc_transceiver_switch(priv, 0);
+ can_led_event(ndev, CAN_LED_EVENT_STOP);
+
return 0;
}
@@ -961,6 +968,9 @@ static int ti_hecc_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "register_candev() failed\n");
goto probe_exit_clk;
}
+
+ devm_can_led_init(ndev);
+
dev_info(&pdev->dev, "device registered (reg_base=%p, irq=%u)\n",
priv->base, (u32) ndev->irq);
--
1.7.12.1
next prev parent reply other threads:[~2012-12-16 11:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 11:08 [PATCH 0/9] tx/rx LED trigger support Fabio Baltieri
2012-12-16 11:08 ` [PATCH 1/9] can: add " Fabio Baltieri
2012-12-17 7:28 ` Bernd Krumboeck
2012-12-17 9:34 ` Kurt Van Dijck
2012-12-17 17:41 ` Fabio Baltieri
2012-12-17 20:20 ` "Bernd Krumböck"
2012-12-17 21:42 ` Fabio Baltieri
2012-12-18 6:02 ` "Bernd Krumböck"
2012-12-16 11:08 ` [PATCH 2/9] can: flexcan: add " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 3/9] can: at91_can: " Fabio Baltieri
2012-12-16 11:08 ` Fabio Baltieri [this message]
2012-12-16 11:08 ` [PATCH 5/9] can: c_can: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 6/9] can: mcp251x: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 7/9] can: sja1000: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 8/9] can: export a safe netdev_priv wrapper for candev Fabio Baltieri
2012-12-16 11:08 ` [PATCH 9/9] can: rename LED trigger name on netdev renames Fabio Baltieri
2012-12-16 22:37 ` [PATCH 0/9] tx/rx LED trigger support Marc Kleine-Budde
2012-12-16 22:51 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355656113-9562-5-git-send-email-fabio.baltieri@gmail.com \
--to=fabio.baltieri@gmail.com \
--cc=anantgole@ti.com \
--cc=kurt.van.dijck@eia.be \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).