From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 2/3] can: dev: remove do_get_state() form can_fill_info()
Date: Mon, 7 Oct 2013 16:46:07 +0200 [thread overview]
Message-ID: <1381157168-24588-3-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1381157168-24588-1-git-send-email-mkl@pengutronix.de>
As there is no driver that implements do_get_state(), remove the call from
can_fill_info().
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/dev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
index f9cba41..54eca2f 100644
--- a/drivers/net/can/dev.c
+++ b/drivers/net/can/dev.c
@@ -724,8 +724,6 @@ static int can_fill_info(struct sk_buff *skb, const struct net_device *dev)
struct can_berr_counter bec;
enum can_state state = priv->state;
- if (priv->do_get_state)
- priv->do_get_state(dev, &state);
if (nla_put_u32(skb, IFLA_CAN_STATE, state) ||
nla_put(skb, IFLA_CAN_CTRLMODE, sizeof(cm), &cm) ||
nla_put_u32(skb, IFLA_CAN_RESTART_MS, priv->restart_ms) ||
--
1.8.4.rc3
next prev parent reply other threads:[~2013-10-07 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-07 14:46 [PATCH 0/3] remove do_get_state() callback Marc Kleine-Budde
2013-10-07 14:46 ` [PATCH 1/3] can: ti_hecc: remove priv->can.do_get_state() callback Marc Kleine-Budde
2013-10-07 14:46 ` Marc Kleine-Budde [this message]
2013-10-07 14:46 ` [PATCH 3/3] can: dev: remove do_get_state() callback from struct can_priv Marc Kleine-Budde
2013-10-07 19:25 ` [PATCH 0/3] remove do_get_state() callback Wolfgang Grandegger
2013-10-07 19:39 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381157168-24588-3-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).