Linux CAN drivers development
 help / color / mirror / Atom feed
From: "Max S." <max@schneidersoft.net>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can <linux-can@vger.kernel.org>
Subject: Re: GS_USB
Date: Mon, 07 Oct 2013 19:52:26 +0000	[thread overview]
Message-ID: <1381175546.21207.37.camel@blackbox> (raw)
In-Reply-To: <5e3f6029b128db63c69664deed10c5d6@grandegger.com>

On Mon, 2013-10-07 at 16:37 +0200, Wolfgang Grandegger wrote:
> Will not find time for the review today...

no problem.

> The CAN controller does not do any asynchronous error reporting,
> right? This will limit the usability of this device, especially
> CAN applications relying on that feature will not work. Any chance
> to add asynchronous error reporting to the firmware?

Only CAN_ERR_CRTL_RX_OVERFLOW is currently reported (possible when host
is too slow).
CAN_ERR_CRTL_TX_OVERFLOW is impossible due to the driver design
(tx context + echo).

Which errors are most important to the applications you mentioned?

The hardware does not allow for the sensing of the CAN_ERR_TRX_* errors.
I can sense some  CAN_ERR_PROT_* errors, as well as all CAN_ERR_CRTL_*
errors.

In firmware it is possible to queue error/status frames much like normal
frames. So they would show up in the receive callback... Thats what you
meant by asynchronous right?

regards,
Max Schneider.


  reply	other threads:[~2013-10-07 19:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 12:31 GS_USB Max S.
2013-10-04 13:23 ` GS_USB Marc Kleine-Budde
2013-10-05 20:36 ` GS_USB Wolfgang Grandegger
2013-10-07 14:22   ` GS_USB Max S.
2013-10-07 14:37     ` GS_USB Wolfgang Grandegger
2013-10-07 19:52       ` Max S. [this message]
2013-10-07 20:30         ` GS_USB Wolfgang Grandegger
2013-11-03 17:12           ` GS_USB Max S.
2013-11-03 19:42             ` GS_USB Wolfgang Grandegger
2013-11-09 23:19             ` GS_USB Wolfgang Grandegger
2013-11-11  2:10               ` GS_USB Max S.
2013-11-11  8:05                 ` GS_USB Wolfgang Grandegger
2013-11-11 15:41                   ` GS_USB Oliver Hartkopp
     [not found]                     ` <1384199350.3483.20.camel@blackbox>
2013-11-11 21:49                       ` GS_USB Oliver Hartkopp
2013-11-15 10:39                         ` GS_USB Max S.
2013-11-23 16:05                           ` GS_USB Max S.
2013-12-04 21:17                             ` GS_USB Max S.
2013-12-05 19:05                               ` GS_USB Oliver Hartkopp
2013-12-05 19:07                                 ` GS_USB Oliver Hartkopp
2013-12-09 17:53                                   ` GS_USB Max S.
2013-12-05 20:18                               ` GS_USB Wolfgang Grandegger
2013-12-05 20:42                                 ` GS_USB Wolfgang Grandegger
2013-12-07 10:06                             ` GS_USB Wolfgang Grandegger
2013-12-09 10:52                               ` GS_USB Marc Kleine-Budde
2013-12-09 13:15                                 ` GS_USB Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381175546.21207.37.camel@blackbox \
    --to=max@schneidersoft.net \
    --cc=linux-can@vger.kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox