From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thor Thayer <tthayer@altera.com>
Subject: Re: [PATCH] net: c_can: Add support for D_CAN module RAM Init.
Date: Thu, 17 Apr 2014 09:36:55 -0500
Message-ID: <1397745415.31413.2.camel@dinh-ubuntu>
References: <1397672973-3480-1-git-send-email-tthayer@altera.com>
	 <1397672973-3480-2-git-send-email-tthayer@altera.com>
	 <alpine.DEB.2.02.1404162312020.22697@ionos.tec.linutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Return-path: <linux-can-owner@vger.kernel.org>
Received: from mail-bl2on0108.outbound.protection.outlook.com ([65.55.169.108]:51953
	"EHLO na01-bl2-obe.outbound.protection.outlook.com"
	rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
	id S1750736AbaDQObQ convert rfc822-to-8bit (ORCPT
	<rfc822;linux-can@vger.kernel.org>); Thu, 17 Apr 2014 10:31:16 -0400
In-Reply-To: <alpine.DEB.2.02.1404162312020.22697@ionos.tec.linutronix.de>
Sender: linux-can-owner@vger.kernel.org
List-ID: <linux-can.vger.kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, socketcan@hartkopp.net, anilkumar@ti.com, tthayer.linux@gmail.com, "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>

On Wed, 2014-04-16 at 23:13 +0200, Thomas Gleixner wrote:
> 
> On Wed, 16 Apr 2014, tthayer@altera.com wrote:
> 
> > From: Thor Thayer <tthayer@altera.com>
> > 
> > The D_CAN driver was written to support the TI D_CAN implementation
> > which placed the D_CAN RAM reset in a separate register. In the
> > standard D_CAN module the RAM Init is in the D_CAN module so
> > handle the RAM Init differently.
> > +		if (!res) {
> > +			priv->raminit = c_can_hw_raminit;
> > +			priv->raminit_type_flag = 0;
> 
> Can we please make that raminit_type and use proper constants?
> 
> Thanks,
> 
> 	tglx

Yes. I will make these changes. Thanks for reviewing.