linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikita Edward Baruzdin <nebaruzdin@gmail.com>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	wg@grandegger.com, linux-can@vger.kernel.org
Subject: Re: [PATCH 3/4] can: netlink: Add CAN_CTRLMODE_PRESUME_ACK flag
Date: Fri, 11 Jul 2014 18:42:37 +0400	[thread overview]
Message-ID: <1405089757.7790.1.camel@thinkpad> (raw)
In-Reply-To: <53BFE42D.20700@hartkopp.net>

I actually think the word "PRESUME" is good enough. We could also use
"NOT_REQUIRE" instead: it's a bit more explicit, but a bit longer.
At least I couldn't think of anything better.

"NOT_WAIT" doesn't reflect the behaviour precisely in my view.
I also believe that the word "IGNORE" is better when it comes to some
"active" message (that supposes some reaction), like "IGNORE_ERRORS" or
"IGNORE_SERVICE_REQUEST". And ACK is more of a reply than a request for
action.

On Fri, 2014-07-11 at 09:18 -0400, Oliver Hartkopp wrote:
> I tried to find a short name for:
> 
> - do not wait for ack
> - ignore missing ack
> - broadcast that doesn't require an ack
> - ...
> 
> I'm really open for an alternative ;-)
> 
> On 10.07.2014 10:12, Marc Kleine-Budde wrote:
> > On 07/10/2014 04:06 PM, Oliver Hartkopp wrote:
> >> what do you think about this extension.
> >>
> >>  From my side the patchset makes sense.
> >>> +#define CAN_CTRLMODE_PRESUME_ACK    0x40    /* Ignore missing CAN
> >>> ACKs */
> >
> > Is this a good name? Does anyone come up with an alternative/better one?
> >
> > Marc
> >



  reply	other threads:[~2014-07-11 14:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 19:31 [PATCH 1/4] can: sja1000: Add support for CAN_CTRLMODE_LOOPBACK Nikita Edward Baruzdin
2014-07-09 19:31 ` [PATCH 2/4] can: netlink: Remove space before tab Nikita Edward Baruzdin
2014-07-09 19:31 ` [PATCH 3/4] can: netlink: Add CAN_CTRLMODE_PRESUME_ACK flag Nikita Edward Baruzdin
2014-07-10 14:06   ` Oliver Hartkopp
2014-07-10 14:12     ` Marc Kleine-Budde
2014-07-11 13:18       ` Oliver Hartkopp
2014-07-11 14:42         ` Nikita Edward Baruzdin [this message]
2014-07-14 12:21     ` Marc Kleine-Budde
2014-07-15  1:32       ` Oliver Hartkopp
2014-07-09 19:31 ` [PATCH 4/4] can: sja1000: Add support for CAN_CTRLMODE_PRESUME_ACK Nikita Edward Baruzdin
2014-07-10 14:25 ` [PATCH 1/4] can: sja1000: Add support for CAN_CTRLMODE_LOOPBACK Marc Kleine-Budde
2014-07-11 12:13   ` [PATCH v2 " Nikita Edward Baruzdin
2014-07-11 12:13     ` [PATCH v2 2/4] can: netlink: Remove space before tab Nikita Edward Baruzdin
2014-07-11 12:13     ` [PATCH v2 3/4] can: netlink: Add CAN_CTRLMODE_PRESUME_ACK flag Nikita Edward Baruzdin
2014-07-11 12:13     ` [PATCH v2 4/4] can: sja1000: Add support for CAN_CTRLMODE_PRESUME_ACK Nikita Edward Baruzdin
2014-07-15  7:35     ` [PATCH v2 1/4] can: sja1000: Add support for CAN_CTRLMODE_LOOPBACK Marc Kleine-Budde
2014-07-15  8:44       ` Nikita Edward Baruzdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405089757.7790.1.camel@thinkpad \
    --to=nebaruzdin@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).