From: Nikita Edward Baruzdin <nebaruzdin@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [libsocketcan 2/2] Update can_set_ctrlmode() documentation
Date: Tue, 22 Jul 2014 18:42:38 +0400 [thread overview]
Message-ID: <1406040158.13021.1.camel@gmail.com> (raw)
In-Reply-To: <53CE74A8.3090506@pengutronix.de>
On Tue, 2014-07-22 at 16:26 +0200, Marc Kleine-Budde wrote:
> Have you actually compile-tested this change?
>
> > libsocketcan.c:781:52: warning: "/*" within comment [-Wcomment]
> > * #define CAN_CTRLMODE_LOOPBACK 0x01 /* Loopback mode */
>
> ...and it finally fails to build from source. I've fixed this while
> applying the patch.
By compiling just the docs... Sorry, my fault.
prev parent reply other threads:[~2014-07-22 14:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 9:43 CAN_CTRLMODE_PRESUME_ACK follow-up patches Nikita Edward Baruzdin
2014-07-21 9:43 ` [iproute2 1/2] Update CAN netlink header Nikita Edward Baruzdin
2014-07-21 17:51 ` Oliver Hartkopp
2014-07-22 14:09 ` Nikita Edward Baruzdin
2014-07-22 14:23 ` Marc Kleine-Budde
2014-07-21 9:43 ` [iproute2 2/2] iplink: Support for CAN presume-ack feature Nikita Edward Baruzdin
2014-07-21 9:43 ` [libsocketcan 1/2] Update CAN netlink header Nikita Edward Baruzdin
2014-07-21 9:43 ` [libsocketcan 2/2] Update can_set_ctrlmode() documentation Nikita Edward Baruzdin
2014-07-22 14:26 ` Marc Kleine-Budde
2014-07-22 14:42 ` Nikita Edward Baruzdin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406040158.13021.1.camel@gmail.com \
--to=nebaruzdin@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).