From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Subject: [PATCH v4 0/3] Adding support for CAN busses via SPI interface Date: Thu, 24 Jul 2014 12:11:43 +0200 Message-ID: <1406196706-4548-1-git-send-email-sbabic@denx.de> Return-path: Received: from smtp1.ngi.it ([88.149.128.112]:55410 "EHLO smtp1.ngi.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935308AbaGXKSO (ORCPT ); Thu, 24 Jul 2014 06:18:14 -0400 Sender: linux-can-owner@vger.kernel.org List-ID: To: linux-can@vger.kernel.org Cc: Marc Kleine-Budde , Wolfgang Grandegger , Oliver Hartkopp , Stefano Babic Hi all, after some time, I post an updated version of the spi_can driver. Sorry for that, but I had to wait for the requested modifications on the microcontroller's firmware to test it again. The majork change is the GET_CFG message to query the remote CAN microcontroller for the CAN bittiming. I hope also I have fixed all issues from previous reviews. Changes in v4: - added GET_CFG message to query bit timing to the remote controller. - readded this patch to the series - implement GET_CFG message to ask the microcontroller for bittiming consts. - drop set_mode (never called) - drop echo_index (never used) - fix inconsistencies using int variable (int/u32) - add reference to documentation in Kconfig help - s/refTime/ref_time/ - move module parameters on the top - use variable to get sizeof inside kzalloc/memset - fix missing close_candev() in open entry point - fix return values (spi_can_fill_skb_msg()) - not access skb after calling net_receive_skb() - fix minor coding style issues - add missing free_irq() and gpio_free() in probe when fails Changes in v3: - format documentation, check for lines > 80 chars (O. Hartkopp) - patch 2/3 already aqpplied to can-next, removed from patchset - spican.h renamed to spi_can.h - drop further references to i.MX and HCS12, not yet cleaned - drop CAN_DEV depend from Kconfig - drop debug stuff via sysfs, not required in production code - drop debug module parameter, use CAN_DEBUG_DEVICES - drop unused bittiming constant - chksum on as default. It could still be disabled via DT/pdata, but not via module parameter. Changes in v2: - drop all references to i.MX35 and HCS12 Stefano Babic (3): Add documentation for SPI to CAN driver CAN: moved SPI drivers into a separate directory CAN: CAN driver to support multiple CAN bus on SPI interface Documentation/networking/spi_can.txt | 774 +++++++++++++++++ drivers/net/can/Kconfig | 8 +- drivers/net/can/Makefile | 2 +- drivers/net/can/spi/Kconfig | 21 + drivers/net/can/spi/Makefile | 9 + drivers/net/can/{ => spi}/mcp251x.c | 0 drivers/net/can/spi/spi_can.c | 1531 ++++++++++++++++++++++++++++++++++ include/linux/can/platform/spi_can.h | 33 + 8 files changed, 2371 insertions(+), 7 deletions(-) create mode 100644 Documentation/networking/spi_can.txt create mode 100644 drivers/net/can/spi/Kconfig create mode 100644 drivers/net/can/spi/Makefile rename drivers/net/can/{ => spi}/mcp251x.c (100%) create mode 100644 drivers/net/can/spi/spi_can.c create mode 100644 include/linux/can/platform/spi_can.h -- 1.9.1