Linux CAN drivers development
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Gregor Herburger <gregor.herburger@ew.tq-group.com>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Marc Kleine-Budde <mkl@pengutronix.de>,
	linux@ew.tq-group.com,  alexander.stein@ew.tq-group.com,
	"David S. Miller" <davem@davemloft.net>,
	 Eric Dumazet <edumazet@google.com>,
	Conor Dooley <conor+dt@kernel.org>,
	 Thomas Kopp <thomas.kopp@microchip.com>,
	 Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	 Jakub Kicinski <kuba@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 netdev@vger.kernel.org,
	 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	 devicetree@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH 4/4] dt-binding: can: mcp251xfd: add gpio-controller property
Date: Wed, 17 Apr 2024 09:46:05 -0500	[thread overview]
Message-ID: <171336511901.2347835.5918715791284546096.robh@kernel.org> (raw)
In-Reply-To: <20240417-mcp251xfd-gpio-feature-v1-4-bc0c61fd0c80@ew.tq-group.com>


On Wed, 17 Apr 2024 15:43:57 +0200, Gregor Herburger wrote:
> The mcp251xfd has two pins that can be used as gpio. Add gpio-controller
> property to binding description.
> 
> Signed-off-by: Gregor Herburger <gregor.herburger@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/can/microchip,mcp251xfd.yaml: properties: '#gpio-cells' is a dependency of 'gpio-controller'
	from schema $id: http://devicetree.org/meta-schemas/gpios.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240417-mcp251xfd-gpio-feature-v1-4-bc0c61fd0c80@ew.tq-group.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-04-17 14:46 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 13:43 [PATCH 0/4] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-04-17 13:43 ` [PATCH 1/4] can: mcp251xfd: stop timestamp before sending chip to sleep Gregor Herburger
2024-04-24  8:24   ` Marc Kleine-Budde
2024-04-25  5:14     ` Gregor Herburger
2024-04-24 11:54   ` Marc Kleine-Budde
2024-04-25  5:17     ` Gregor Herburger
2024-04-25  6:29       ` Marc Kleine-Budde
2024-04-25  9:44         ` Gregor Herburger
2024-04-17 13:43 ` [PATCH 2/4] can: mcp251xfd: mcp251xfd_regmap_crc_write(): workaround for errata 5 Gregor Herburger
2024-04-23 16:46   ` Simon Horman
2024-04-24 10:54   ` Vincent MAILHOL
2024-04-24 11:51   ` Marc Kleine-Budde
2024-04-25  5:37     ` Gregor Herburger
2024-04-17 13:43 ` [PATCH 3/4] can: mcp251xfd: add gpio functionality Gregor Herburger
2024-04-24  8:15   ` Marc Kleine-Budde
2024-04-24  9:10   ` Marc Kleine-Budde
2024-04-24  9:15   ` Marc Kleine-Budde
2024-04-24  9:35   ` Marc Kleine-Budde
2024-04-24 13:01     ` Marc Kleine-Budde
2024-04-17 13:43 ` [PATCH 4/4] dt-binding: can: mcp251xfd: add gpio-controller property Gregor Herburger
2024-04-17 14:46   ` Rob Herring [this message]
2024-04-19 16:36   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171336511901.2347835.5918715791284546096.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=gregor.herburger@ew.tq-group.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=thomas.kopp@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox