From: netdev-bot+sashiko@kernel.org
To: mkl@pengutronix.de
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
linux-can@vger.kernel.org, kernel@pengutronix.de,
socketcan@hartkopp.net, dev.kurt@vandijck-laurijssen.be
Subject: Re: [PATCH net-next 09/12] can: ifi_canfd: don't discard the IRQ lookup error in probe
Date: Thu, 19 Nov 2026 09:54:32 +0000 [thread overview]
Message-ID: <179508207207.3136.4339679451321533549@kernel.org> (raw)
In-Reply-To: <20261118092955.1283165-10-mkl@pengutronix.de>
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit message for "can: ifi_canfd: don't discard the IRQ
lookup error in probe" presents a user-visible failure as fact ("The…
--
can: ifi_canfd: don't discard the IRQ lookup error in probe
This commit changes ifi_canfd_plat_probe() to return the error from
platform_get_irq() unchanged, instead of turning every failure into
-EINVAL. As a result, -EPROBE_DEFER now reaches the driver core.
Link: https://patch.msgid.link/165f3fccb8faf1db65e8f18dbee4694c95266e31.1792118040.git.chaosheng.qu.linux@gmail.com
> The driver matches through an of_match_table ("ifi,canfd-1.0"), so
> of_irq_get() returns -EPROBE_DEFER while the interrupt controller has not
> been probed. The probe overwrites it and the driver core stops retrying,
> leaving the device unbound even though the interrupt controller appears
> later.
>
> Return the lookup error unchanged, as the neighbouring CAN platform drivers
> do, e.g. previous commit ("can: cc770: don't discard the IRQ lookup error
> in probe").
[Severity: Low]
The code change looks correct, and the mechanism is real. of_irq_get()
returns -EPROBE_DEFER when irq_find_host() finds no domain, and the old
return -EINVAL made that a permanent probe failure.
Can any in-tree platform actually hit this failure? The "ifi,canfd-1.0"
compatible appears only in ifi_canfd_of_table. No binding document or DTS
uses it, and the only testing note is "Build tested on x86_64".
The message reads like a fix for a confirmed user-visible failure. It has
no Fixes: tag, though, and it doesn't say the problem is latent. With
neither, a stable backporter or AUTOSEL can't tell whether to take it or
how far back it should go.
The cc770 commit that this message uses as its model was edited to say
"This is a robustness and consistency cleanup, this issue has not been
seen on real hardware."
Could this message use the same framing? The other option would be a
Fixes: tag naming the commit that added the driver.
A smaller point: "previous commit" doesn't match the applied history. The
commit directly before this one is "can: janz-ican3: don't discard the IRQ
lookup error in probe", not the cc770 change.
The cc770 change is already applied. Would the usual commit <sha>
("title") form be clearer here?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261118092955.1283165-2-mkl%40pengutronix.de
next prev parent reply other threads:[~2026-11-19 9:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 9:11 [PATCH net-next 0/12] pull-request: can-next 2026-11-18 Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 01/12] MAINTAINERS: add entry for PEAK-System CAN drivers Marc Kleine-Budde
2026-11-18 9:38 ` netdev-bot+sinfo
2026-11-18 9:45 ` Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 02/12] can: raw: remove redundant NULL check before netdev_hold() Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 03/12] can: dev: remove unused safe_candev_priv() Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 04/12] can: convert to DEFINE_SIMPLE_DEV_PM_OPS() Marc Kleine-Budde
2026-11-19 9:54 ` netdev-bot+sashiko
2026-11-19 11:19 ` Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 05/12] can: cc770: don't discard the IRQ lookup error in probe Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 06/12] can: sun4i_can: " Marc Kleine-Budde
2026-11-19 9:32 ` sashiko-bot
2026-11-19 9:37 ` Marc Kleine-Budde
2026-11-19 9:54 ` netdev-bot+sashiko
2026-11-18 9:11 ` [PATCH net-next 07/12] can: at91_can: " Marc Kleine-Budde
2026-11-19 9:54 ` netdev-bot+sashiko
2026-11-18 9:11 ` [PATCH net-next 08/12] can: janz-ican3: " Marc Kleine-Budde
2026-11-19 9:54 ` netdev-bot+sashiko
2026-11-18 9:11 ` [PATCH net-next 09/12] can: ifi_canfd: " Marc Kleine-Budde
2026-11-19 9:54 ` netdev-bot+sashiko [this message]
2026-11-18 9:11 ` [PATCH net-next 10/12] can: remove Softing CANcard driver Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 11/12] can: ucan: fix repeated word 'is' in comment Marc Kleine-Budde
2026-11-18 9:11 ` [PATCH net-next 12/12] can: xilinx_can: set CAN FD flags on received frames Marc Kleine-Budde
2026-11-19 9:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179508207207.3136.4339679451321533549@kernel.org \
--to=netdev-bot+sashiko@kernel.org \
--cc=davem@davemloft.net \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox