Re: [PATCH 5/7] can: dev: add berr_limit infrastrucutre

[Alexander Stein <alexander.stein@systec-electronic.com>]

Hello Marc,

On Monday 07 October 2013 16:40:38, Marc Kleine-Budde wrote:
> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
> index bda1888..969d3cd 100644
> --- a/drivers/net/can/dev.c
> +++ b/drivers/net/can/dev.c
> @@ -486,6 +486,29 @@ void can_bus_off(struct net_device *dev)
>  }
>  EXPORT_SYMBOL_GPL(can_bus_off);
>  
> +static void can_berr_restart(unsigned long data)
> +{
> +	struct net_device *dev = (struct net_device *)data;
> +	struct can_priv *priv = netdev_priv(dev);
> +
> +	netdev_dbg(dev, "berr-restart\n");
> +	priv->do_berr_restart(dev);
     ^^^^^^^^^^^^^^^^^^^^^^^^
see below!

> +}
> +
> +void can_berr_limit(struct net_device *dev)
> +{
> +	struct can_priv *priv = netdev_priv(dev);
> +
> +	if (priv->berr_limit_delay) {
> +		netdev_dbg(dev, "berr-limit\n");
> +		mod_timer(&priv->berr_limit_timer,
> +			  jiffies + priv->berr_limit_delay);
> +	} else {
> +		priv->do_berr_restart(dev);
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
Here you are silently requiring that do_berr_restart is non-NULL. I know that the driver has to properly set this when using can_berr_limit, but it might seem confusing.

Regards,
Alexander