From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stephane Grosjean <s.grosjean@peak-system.com>,
Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can: peak/pci: fix potential bug when probe() fails
Date: Mon, 27 Nov 2017 15:16:25 +0100 [thread overview]
Message-ID: <1a5a00a0-e7a0-ec0d-2782-5ce68fb5fbda@pengutronix.de> (raw)
In-Reply-To: <20171123144435.12282-1-s.grosjean@peak-system.com>
[-- Attachment #1.1: Type: text/plain, Size: 855 bytes --]
On 11/23/2017 03:44 PM, Stephane Grosjean wrote:
> PCI/PCIe drivers for PEAK-System CAN/CAN-FD interfaces do some access to the
> PCI config during probing. In case one of these accesses fails, a POSITIVE
> PCIBIOS_xxx error code is returned back. This POSITIVE error code MUST be
> converted into a NEGATIVE errno for the probe() function to indicate it
> failed. Using the pcibios_err_to_errno() function, we make sure that the
> return code will always be negative.
>
> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
Applied to can.
Tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2017-11-27 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 14:44 [PATCH] can: peak/pci: fix potential bug when probe() fails Stephane Grosjean
2017-11-27 14:16 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a5a00a0-e7a0-ec0d-2782-5ce68fb5fbda@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox