From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>,
Thomseeen <thwa1@web.de>,
linux-can@vger.kernel.org
Subject: Re: [PATCH] isotp: do not validate RX address when the broadcast flag is active
Date: Sat, 5 Dec 2020 22:23:14 +0100 [thread overview]
Message-ID: <1e1ab72a-18e3-e237-331a-6c15ffd651ad@pengutronix.de> (raw)
In-Reply-To: <d7f4c720-199f-8837-829e-653c435f52d1@hartkopp.net>
[-- Attachment #1.1: Type: text/plain, Size: 953 bytes --]
On 12/5/20 10:15 PM, Oliver Hartkopp wrote:
> On 04.12.20 14:55, Thomseeen wrote:
>> EADDRNOTAVAIL shouldn't be thrown when an invalid RX address (e.g. NO_CAN_ID)
>> is set while the socket is used with the CAN_ISOTP_SF_BROADCAST flag.
>>
>> Signed-off-by: Thomseeen <thwa1@web.de>
>
> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Should this be squashed into "support for functional addressing"?
Can you re-post the two or three isotp patches, as they should go into
can-next/net-next?
> 98bef9295d07 can: isotp: isotp_setsockopt(): block setsockopt on bound sockets
> 21f10f1b5c3a can: isotp: add SF_BROADCAST support for functional addressing
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-12-05 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 13:55 [PATCH] isotp: do not validate RX address when the broadcast flag is active Thomseeen
2020-12-05 20:59 ` Marc Kleine-Budde
2020-12-05 21:05 ` Oliver Hartkopp
2020-12-05 21:15 ` thwa1
2020-12-05 21:15 ` Oliver Hartkopp
2020-12-05 21:23 ` Marc Kleine-Budde [this message]
2020-12-06 10:32 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e1ab72a-18e3-e237-331a-6c15ffd651ad@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thwa1@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox