From: "Eric Bénard" <eric@eukrea.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH] can: flexcan: add PM support
Date: Tue, 8 May 2012 19:14:59 +0200 [thread overview]
Message-ID: <20120508191459.703c4369@eb-e6520> (raw)
In-Reply-To: <4FA93FC1.7030808@pengutronix.de>
Le Tue, 08 May 2012 17:46:09 +0200,
Marc Kleine-Budde <mkl@pengutronix.de> a écrit :
> On 05/08/2012 05:30 PM, Eric Bénard wrote:
> > Hi Marc,
> >
> > Le Tue, 08 May 2012 17:18:34 +0200,
> > Marc Kleine-Budde <mkl@pengutronix.de> a écrit :
> >
> >> On 05/08/2012 05:12 PM, Eric Bénard wrote:
> >>> tested on an i.MX257
> >>
> >> What about the transceiver? Does is make sense to switch it off, too?
> >>
> > this could make sense on platform which have a transceiver with an
> > enable input. I can add flexcan_transceiver_switch after/before
> > flexcan_chip_disable/enable but won't be able to test that feature.
>
> I looked at two ethernet drivers: ethernet/intel/ixgbe/ixgbe_main.c and
> ethernet/intel/ixgbe/ixgbe_main.c and AFAICS they basically do the same
> as in open/close. (btw: the flexcan driver switches the transceiver
> on/off on open/close.) I haven't implemented any network driver pm yet,
> but what is a driver supposed to do in suspend/resume?
>
concerning the transceiver : that depends if you need to resume when
receiving a message on the CAN bus in which case you can't disable the
transceiver (btw, I have an other patch which enable wakeup when
receiving a message on the CAN bus, but I need to clean and test it
again).
Eric
next prev parent reply other threads:[~2012-05-08 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 15:12 [PATCH] can: flexcan: add PM support Eric Bénard
2012-05-08 15:18 ` Marc Kleine-Budde
2012-05-08 15:30 ` Eric Bénard
2012-05-08 15:46 ` Marc Kleine-Budde
2012-05-08 17:14 ` Eric Bénard [this message]
2012-05-08 17:38 ` Oliver Hartkopp
2012-05-08 18:02 ` Eric Bénard
2012-05-08 18:34 ` Marc Kleine-Budde
2012-05-09 8:16 ` Kurt Van Dijck
2012-05-09 14:35 ` Oliver Hartkopp
2012-05-09 14:53 ` [PATCH] can: trx support Kurt Van Dijck
2012-05-08 19:09 ` [PATCH] can: flexcan: add PM support Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508191459.703c4369@eb-e6520 \
--to=eric@eukrea.com \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox