From: Thomas Graf <tgraf@suug.ch>
To: Michal Sojka <sojkam1@fel.cvut.cz>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>,
Rostislav Lisovy <lisovy@gmail.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
lartc@vger.kernel.org, pisa@cmp.felk.cvut.cz
Subject: Re: [RFC] net/sched/em_canid: Ematch rule to match CAN frames according to their CAN IDs
Date: Wed, 13 Jun 2012 08:18:28 -0400 [thread overview]
Message-ID: <20120613121828.GP28598@canuck.infradead.org> (raw)
In-Reply-To: <878vfr7d4l.fsf@steelpick.2x.cz>
On Wed, Jun 13, 2012 at 11:52:10AM +0200, Michal Sojka wrote:
> The performance of ematch might be slightly lower than of standalone
> classifier. Rosta will compare the performance soon.
I think it doesn't make a difference, there is no additional locking
involved. Numbers definitely welcome though.
> > E.g. is it still possible to add additional ematches like checking for
> > patterns inside can_frame.data[] (which is located in skb->data) with
> > ematch_u32 or e.g. ematch_text ??
>
> AFAIK, this should be possible and it will be a big advantage over
> implementation as a standalone classifier.
Definitely and the real advantage is that you can combine these
using logic operators.
prev parent reply other threads:[~2012-06-13 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 13:48 [RFC] net/sched/em_canid: Ematch rule to match CAN frames according to their CAN IDs Rostislav Lisovy
2012-06-12 14:03 ` Eric Dumazet
2012-06-12 14:33 ` Eric Dumazet
2012-06-12 14:50 ` Rostislav Lisovy
2012-06-12 15:42 ` Oliver Hartkopp
2012-06-13 9:52 ` Michal Sojka
2012-06-13 12:18 ` Thomas Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613121828.GP28598@canuck.infradead.org \
--to=tgraf@suug.ch \
--cc=eric.dumazet@gmail.com \
--cc=lartc@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=lisovy@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pisa@cmp.felk.cvut.cz \
--cc=socketcan@hartkopp.net \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).