From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-arm-kernel@lists.infradead.org, linux-can@vger.kernel.org
Subject: Re: [PATCH] can: flexcan: add a regulator for transceiver
Date: Tue, 3 Jul 2012 14:07:47 +0100 [thread overview]
Message-ID: <20120703130747.GD25995@sirena.org.uk> (raw)
In-Reply-To: <1341319571-27763-1-git-send-email-shawn.guo@linaro.org>
On Tue, Jul 03, 2012 at 08:46:11PM +0800, Shawn Guo wrote:
> + if (priv->reg_xcvr) {
> + if (on)
> + regulator_enable(priv->reg_xcvr);
> + else
> + regulator_disable(priv->reg_xcvr);
> + }
No, the regulator API will stub itself out if not enabled, and if the
supply is fixed then a fixed voltage regulator will do the job. We
shouldn't be open coding this stuff in individual users.
next prev parent reply other threads:[~2012-07-03 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 12:46 [PATCH] can: flexcan: add a regulator for transceiver Shawn Guo
2012-07-03 13:07 ` Mark Brown [this message]
2012-07-03 14:18 ` Shawn Guo
2012-07-03 14:46 ` Mark Brown
2012-07-03 15:28 ` Shawn Guo
2012-07-03 16:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703130747.GD25995@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox